Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

watchdog: st_lpc: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20230303213716.2123717-33-u.kleine-koenig@pengutronix.de
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>

authored by

Uwe Kleine-König and committed by
Wim Van Sebroeck
e7a84d45 70b5b2b2

+2 -4
+2 -4
drivers/watchdog/st_lpc_wdt.c
··· 239 239 return ret; 240 240 } 241 241 242 - static int st_wdog_remove(struct platform_device *pdev) 242 + static void st_wdog_remove(struct platform_device *pdev) 243 243 { 244 244 struct st_wdog *st_wdog = watchdog_get_drvdata(&st_wdog_dev); 245 245 246 246 st_wdog_setup(st_wdog, false); 247 - 248 - return 0; 249 247 } 250 248 251 249 static int st_wdog_suspend(struct device *dev) ··· 293 295 .of_match_table = st_wdog_match, 294 296 }, 295 297 .probe = st_wdog_probe, 296 - .remove = st_wdog_remove, 298 + .remove_new = st_wdog_remove, 297 299 }; 298 300 module_platform_driver(st_wdog_driver); 299 301