tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

NFS: remove redundant __private attribute from nfs_page_class

The nfs_page_class tracepoint uses a pointer for the 'req' field marked
with the __private attribute. This causes Sparse to complain about
dereferencing a private pointer within the trace ring buffer context,
specifically during the TP_fast_assign() operation.

This fixes a Sparse warning introduced in commit b6ef079fd984 ("nfs:
more in-depth tracing of writepage events") by removing the redundant
__private attribute from the 'req' field.

Reviewed-by: Benjamin Coddington <bcodding@hammerspace.com>
Signed-off-by: Sean Chang <seanwascoding@gmail.com>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>

authored by

Sean Chang and committed by
Trond Myklebust e8a44ae8 6e7daa3d

+1 -1
+1 -1
fs/nfs/nfstrace.h
··· 1496 1496 __field(dev_t, dev) 1497 1497 __field(u32, fhandle) 1498 1498 __field(u64, fileid) 1499 - __field(const struct nfs_page *__private, req) 1499 + __field(const struct nfs_page *, req) 1500 1500 __field(loff_t, offset) 1501 1501 __field(unsigned int, count) 1502 1502 __field(unsigned long, flags)