tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

nvme: add WQ_PERCPU to alloc_workqueue users

This continues the effort to refactor workqueue APIs, which began with
the introduction of new workqueues and a new alloc_workqueue flag in:

commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq")
commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag")

The refactoring is going to alter the default behavior of
alloc_workqueue() to be unbound by default.

With the introduction of the WQ_PERCPU flag (equivalent to !WQ_UNBOUND),
any alloc_workqueue() caller that doesn’t explicitly specify WQ_UNBOUND
must now use WQ_PERCPU. For more details see the Link tag below.

In order to keep alloc_workqueue() behavior identical, explicitly request
WQ_PERCPU.

Link: https://lore.kernel.org/all/20250221112003.1dSuoGyc@linutronix.de/
Suggested-by: Tejun Heo <tj@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
Signed-off-by: Keith Busch <kbusch@kernel.org>

authored by

Marco Crivellari and committed by
Keith Busch e8e1a4c0 12f5fb5e

+4 -3
+3 -2
drivers/nvme/target/core.c
··· 1942 1942 if (!nvmet_bvec_cache) 1943 1943 return -ENOMEM; 1944 1944 1945 - zbd_wq = alloc_workqueue("nvmet-zbd-wq", WQ_MEM_RECLAIM, 0); 1945 + zbd_wq = alloc_workqueue("nvmet-zbd-wq", WQ_MEM_RECLAIM | WQ_PERCPU, 1946 + 0); 1946 1947 if (!zbd_wq) 1947 1948 goto out_destroy_bvec_cache; 1948 1949 1949 1950 buffered_io_wq = alloc_workqueue("nvmet-buffered-io-wq", 1950 - WQ_MEM_RECLAIM, 0); 1951 + WQ_MEM_RECLAIM | WQ_PERCPU, 0); 1951 1952 if (!buffered_io_wq) 1952 1953 goto out_free_zbd_work_queue; 1953 1954
+1 -1
drivers/nvme/target/tcp.c
··· 2225 2225 int ret; 2226 2226 2227 2227 nvmet_tcp_wq = alloc_workqueue("nvmet_tcp_wq", 2228 - WQ_MEM_RECLAIM | WQ_HIGHPRI, 0); 2228 + WQ_MEM_RECLAIM | WQ_HIGHPRI | WQ_PERCPU, 0); 2229 2229 if (!nvmet_tcp_wq) 2230 2230 return -ENOMEM; 2231 2231