tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

ntfs: add missing newlines to pr_err() messages

There is an inconsistent use of pr_err() statements in the current code.
Many error messages are missing the \n termination, what results in the
messages being printed with a delay, only after a next printk() line is
printed. It prevents relying on printk() to monitor the driver errors.
This patch is modifying only text messages, no functional change.

Signed-off-by: Woody Suwalski <terraluna977@gmail.com>
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>

authored by

Woody Suwalski and committed by
Namjae Jeon ea3566a3 d7bf74c9

+15 -15
+13 -13
fs/ntfs/attrib.c
··· 2062 2062 2063 2063 /* Rigorous consistency checks. */ 2064 2064 if (!m || !pos || pos < (u8 *)m) { 2065 - pr_err("%s: pos=%p m=%p", __func__, pos, m); 2065 + pr_err("%s: pos=%p m=%p\n", __func__, pos, m); 2066 2066 return -EINVAL; 2067 2067 } 2068 2068 ··· 2240 2240 err = ntfs_attr_can_be_non_resident(ni->vol, type); 2241 2241 if (err) { 2242 2242 if (err == -EPERM) 2243 - pr_err("Attribute can't be non resident"); 2243 + pr_err("Attribute can't be non resident\n"); 2244 2244 else 2245 - pr_err("ntfs_attr_can_be_non_resident failed"); 2245 + pr_err("ntfs_attr_can_be_non_resident failed\n"); 2246 2246 return err; 2247 2247 } 2248 2248 2249 2249 /* Locate place where record should be. */ 2250 2250 ctx = ntfs_attr_get_search_ctx(ni, NULL); 2251 2251 if (!ctx) { 2252 - pr_err("%s: Failed to get search context", __func__); 2252 + pr_err("%s: Failed to get search context\n", __func__); 2253 2253 return -ENOMEM; 2254 2254 } 2255 2255 /* ··· 2260 2260 err = ntfs_attr_find(type, name, name_len, CASE_SENSITIVE, NULL, 0, ctx); 2261 2261 if (!err) { 2262 2262 err = -EEXIST; 2263 - pr_err("Attribute 0x%x already present", type); 2263 + pr_err("Attribute 0x%x already present\n", type); 2264 2264 goto put_err_out; 2265 2265 } 2266 2266 if (err != -ENOENT) { 2267 - pr_err("ntfs_attr_find failed"); 2267 + pr_err("ntfs_attr_find failed\n"); 2268 2268 err = -EIO; 2269 2269 goto put_err_out; 2270 2270 } ··· 2279 2279 sizeof(a->data.non_resident.compressed_size) : 0); 2280 2280 err = ntfs_make_room_for_attr(ctx->mrec, (u8 *) ctx->attr, length); 2281 2281 if (err) { 2282 - pr_err("Failed to make room for attribute"); 2282 + pr_err("Failed to make room for attribute\n"); 2283 2283 goto put_err_out; 2284 2284 } 2285 2285 ··· 2319 2319 if (type != AT_ATTRIBUTE_LIST && NInoAttrList(base_ni)) { 2320 2320 err = ntfs_attrlist_entry_add(ni, a); 2321 2321 if (err) { 2322 - pr_err("Failed add attr entry to attrlist"); 2322 + pr_err("Failed add attr entry to attrlist\n"); 2323 2323 ntfs_attr_record_resize(m, a, 0); 2324 2324 goto put_err_out; 2325 2325 } ··· 2334 2334 err = ntfs_attr_lookup(type, name, name_len, CASE_SENSITIVE, 2335 2335 lowest_vcn, NULL, 0, ctx); 2336 2336 if (err) { 2337 - pr_err("%s: attribute lookup failed", __func__); 2337 + pr_err("%s: attribute lookup failed\n", __func__); 2338 2338 ntfs_attr_put_search_ctx(ctx); 2339 2339 return err; 2340 2340 ··· 2825 2825 ctx = ntfs_attr_get_search_ctx(base_ni, NULL); 2826 2826 if (!ctx) { 2827 2827 err = -ENOMEM; 2828 - pr_err("%s: Failed to get search context", __func__); 2828 + pr_err("%s: Failed to get search context\n", __func__); 2829 2829 goto err_out; 2830 2830 } 2831 2831 ··· 4615 4615 * which is what Windows NT4 does, too. 4616 4616 */ 4617 4617 if (NInoEncrypted(ni)) { 4618 - pr_err("Failed to truncate encrypted attribute"); 4618 + pr_err("Failed to truncate encrypted attribute\n"); 4619 4619 return -EACCES; 4620 4620 } 4621 4621 ··· 4669 4669 * which is what Windows NT4 does, too. 4670 4670 */ 4671 4671 if (NInoEncrypted(ni)) { 4672 - pr_err("Failed to truncate encrypted attribute"); 4672 + pr_err("Failed to truncate encrypted attribute\n"); 4673 4673 return -EACCES; 4674 4674 } 4675 4675 4676 4676 if (NInoCompressed(ni)) { 4677 - pr_err("Failed to truncate compressed attribute"); 4677 + pr_err("Failed to truncate compressed attribute\n"); 4678 4678 return -EOPNOTSUPP; 4679 4679 } 4680 4680
+1 -1
fs/ntfs/ea.c
··· 613 613 goto out; 614 614 615 615 if (a->data.non_resident.data_size) { 616 - pr_err("Can't change sparsed/compressed for non-empty file"); 616 + pr_err("Can't change sparsed/compressed for non-empty file\n"); 617 617 err = -EOPNOTSUPP; 618 618 goto err_out; 619 619 }
+1 -1
fs/ntfs/runlist.c
··· 1598 1598 for (rlc = rl; rlc->length; rlc++) 1599 1599 if (rlc->lcn < 0) { 1600 1600 if (rlc->lcn != LCN_HOLE && rlc->lcn != LCN_DELALLOC) { 1601 - pr_err("%s: bad runlist", __func__); 1601 + pr_err("%s: bad runlist\n", __func__); 1602 1602 return -EINVAL; 1603 1603 } 1604 1604 return 1;