Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

m68k: implement xor_unlock_is_negative_byte

Using EOR to clear the guaranteed-to-be-set lock bit will test the
negative flag just like the x86 implementation. This should be more
efficient than the generic implementation in filemap.c. It would be
better if m68k had __GCC_ASM_FLAG_OUTPUTS__.

Coldfire doesn't have a byte-sized EOR, so we test bit 7 after the EOR,
which is a second memory access, but it's slightly better than the current
C code.

Link: https://lkml.kernel.org/r/20231004165317.1061855-10-willy@infradead.org
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Cc: Albert Ou <aou@eecs.berkeley.edu>
Cc: Alexander Gordeev <agordeev@linux.ibm.com>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>
Cc: Christian Borntraeger <borntraeger@linux.ibm.com>
Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Heiko Carstens <hca@linux.ibm.com>
Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
Cc: Matt Turner <mattst88@gmail.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Nicholas Piggin <npiggin@gmail.com>
Cc: Palmer Dabbelt <palmer@dabbelt.com>
Cc: Paul Walmsley <paul.walmsley@sifive.com>
Cc: Richard Henderson <richard.henderson@linaro.org>
Cc: Sven Schnelle <svens@linux.ibm.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Vasily Gorbik <gor@linux.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

authored by

Matthew Wilcox (Oracle) and committed by
Andrew Morton
ea845e31 e28ff5dc

+22
+22
arch/m68k/include/asm/bitops.h
··· 319 319 return test_and_change_bit(nr, addr); 320 320 } 321 321 322 + static inline bool xor_unlock_is_negative_byte(unsigned long mask, 323 + volatile unsigned long *p) 324 + { 325 + #ifdef CONFIG_COLDFIRE 326 + __asm__ __volatile__ ("eorl %1, %0" 327 + : "+m" (*p) 328 + : "d" (mask) 329 + : "memory"); 330 + return *p & (1 << 7); 331 + #else 332 + char result; 333 + char *cp = (char *)p + 3; /* m68k is big-endian */ 334 + 335 + __asm__ __volatile__ ("eor.b %1, %2; smi %0" 336 + : "=d" (result) 337 + : "di" (mask), "o" (*cp) 338 + : "memory"); 339 + return result; 340 + #endif 341 + } 342 + #define xor_unlock_is_negative_byte xor_unlock_is_negative_byte 343 + 322 344 /* 323 345 * The true 68020 and more advanced processors support the "bfffo" 324 346 * instruction for finding bits. ColdFire and simple 68000 parts