tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

tg3: simplify tg3_phy_autoneg_cfg

Make use of ethtool_adv_to_mmd_eee_adv_t() to simplify the code.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Heiner Kallweit and committed by
David S. Miller ebb0346a 8306ee08

+4 -13
+4 -13
drivers/net/ethernet/broadcom/tg3.c
··· 4354 4354 if (!err) { 4355 4355 u32 err2; 4356 4356 4357 - val = 0; 4358 - /* Advertise 100-BaseTX EEE ability */ 4359 - if (advertise & ADVERTISED_100baseT_Full) 4360 - val |= MDIO_AN_EEE_ADV_100TX; 4361 - /* Advertise 1000-BaseT EEE ability */ 4362 - if (advertise & ADVERTISED_1000baseT_Full) 4363 - val |= MDIO_AN_EEE_ADV_1000T; 4364 - 4365 - if (!tp->eee.eee_enabled) { 4357 + if (!tp->eee.eee_enabled) 4366 4358 val = 0; 4367 - linkmode_zero(tp->eee.advertised); 4368 - } else { 4369 - mii_eee_cap1_mod_linkmode_t(tp->eee.advertised, val); 4370 - } 4359 + else 4360 + val = ethtool_adv_to_mmd_eee_adv_t(advertise); 4371 4361 4362 + mii_eee_cap1_mod_linkmode_t(tp->eee.advertised, val); 4372 4363 err = tg3_phy_cl45_write(tp, MDIO_MMD_AN, MDIO_AN_EEE_ADV, val); 4373 4364 if (err) 4374 4365 val = 0;