tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

scsi: cxlflash: Drop DID_ALLOC_FAILURE use

DID_ALLOC_FAILURE is internal to the SCSI layer. Drivers must not use it
because:

1. It's not propagated upwards, so SG IO/passthrough users will not see an
error and think a command was successful.

2. There is no handling for it in scsi_decide_disposition() so it results
in entering SCSI error handling.

By the code comment, it looks like the driver wanted a retryable error
code, so this has it use DID_ERROR.

Link: https://lore.kernel.org/r/20220812010027.8251-8-michael.christie@oracle.com
Signed-off-by: Mike Christie <michael.christie@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

authored by

Mike Christie and committed by
Martin K. Petersen ebb54b20 a965d35c

+1 -1
+1 -1
drivers/scsi/cxlflash/main.c
··· 132 132 break; 133 133 case SISL_AFU_RC_OUT_OF_DATA_BUFS: 134 134 /* Retry */ 135 - scp->result = (DID_ALLOC_FAILURE << 16); 135 + scp->result = (DID_ERROR << 16); 136 136 break; 137 137 default: 138 138 scp->result = (DID_ERROR << 16);