tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

spi: dt-bindings: fsl: Correct GPIO flags in the example

IRQ_TYPE_xxx flags are not correct in the context of GPIO flags.
These are simple defines so they could be used in DTS but they will not
have the same meaning: IRQ_TYPE_EDGE_RISING = 1 = GPIO_ACTIVE_LOW.

Correct the example DTS to use proper flags for chip select GPIOs,
assuming the author of the code wanted similar logical behavior:

IRQ_TYPE_EDGE_RISING => GPIO_ACTIVE_HIGH

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Link: https://patch.msgid.link/20260413085947.51047-2-krzysztof.kozlowski@oss.qualcomm.com
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Krzysztof Kozlowski and committed by
Mark Brown ebeef57b c4c3fc87

+3 -3
+3 -3
Documentation/devicetree/bindings/spi/fsl,spi.yaml
··· 59 59 60 60 examples: 61 61 - | 62 - #include <dt-bindings/interrupt-controller/irq.h> 62 + #include <dt-bindings/gpio/gpio.h> 63 63 64 64 spi@4c0 { 65 65 compatible = "fsl,spi"; ··· 67 67 cell-index = <0>; 68 68 interrupts = <82 0>; 69 69 mode = "cpu"; 70 - cs-gpios = <&gpio 18 IRQ_TYPE_EDGE_RISING // device reg=<0> 71 - &gpio 19 IRQ_TYPE_EDGE_RISING>; // device reg=<1> 70 + cs-gpios = <&gpio 18 GPIO_ACTIVE_HIGH>, // device reg=<0> 71 + <&gpio 19 GPIO_ACTIVE_HIGH>; // device reg=<1> 72 72 }; 73 73 74 74 ...