Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
io_uring: cleanup {g,s]etsockopt sqe reading
Add a local variable for the sqe pointer to avoid repetition.
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/8dbac0f9acda2d3842534eeb7ce10d9276b021ae.1743357108.git.asml.silence@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
authored by
Pavel Begunkov
and committed by
Jens Axboe
ed344511
296e1696
+10
-8
+10
-8
io_uring/uring_cmd.c
+10
-8
io_uring/uring_cmd.c
···
307
307
struct io_uring_cmd *cmd,
308
308
unsigned int issue_flags)
309
309
{
310
+
const struct io_uring_sqe *sqe = cmd->sqe;
310
311
bool compat = !!(issue_flags & IO_URING_F_COMPAT);
311
312
int optlen, optname, level, err;
312
313
void __user *optval;
313
314
314
-
level = READ_ONCE(cmd->sqe->level);
315
+
level = READ_ONCE(sqe->level);
315
316
if (level != SOL_SOCKET)
316
317
return -EOPNOTSUPP;
317
318
318
-
optval = u64_to_user_ptr(READ_ONCE(cmd->sqe->optval));
319
-
optname = READ_ONCE(cmd->sqe->optname);
320
-
optlen = READ_ONCE(cmd->sqe->optlen);
319
+
optval = u64_to_user_ptr(READ_ONCE(sqe->optval));
320
+
optname = READ_ONCE(sqe->optname);
321
+
optlen = READ_ONCE(sqe->optlen);
321
322
322
323
err = do_sock_getsockopt(sock, compat, level, optname,
323
324
USER_SOCKPTR(optval),
···
334
333
struct io_uring_cmd *cmd,
335
334
unsigned int issue_flags)
336
335
{
336
+
const struct io_uring_sqe *sqe = cmd->sqe;
337
337
bool compat = !!(issue_flags & IO_URING_F_COMPAT);
338
338
int optname, optlen, level;
339
339
void __user *optval;
340
340
sockptr_t optval_s;
341
341
342
-
optval = u64_to_user_ptr(READ_ONCE(cmd->sqe->optval));
343
-
optname = READ_ONCE(cmd->sqe->optname);
344
-
optlen = READ_ONCE(cmd->sqe->optlen);
345
-
level = READ_ONCE(cmd->sqe->level);
342
+
optval = u64_to_user_ptr(READ_ONCE(sqe->optval));
343
+
optname = READ_ONCE(sqe->optname);
344
+
optlen = READ_ONCE(sqe->optlen);
345
+
level = READ_ONCE(sqe->level);
346
346
optval_s = USER_SOCKPTR(optval);
347
347
348
348
return do_sock_setsockopt(sock, compat, level, optname, optval_s,