tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

drm/bridge: ti-sn65dsi86: Check for CONFIG_PWM using IS_REACHABLE()

Currently CONFIG_PWM is a bool but I intend to change it to tristate. If
CONFIG_PWM=m in the configuration, the cpp symbol CONFIG_PWM isn't
defined and so the PWM code paths in the ti-sn65dsi86 driver are not
used.

The correct way to check for CONFIG_PWM is using IS_REACHABLE which does
the right thing for all cases
CONFIG_DRM_TI_SN65DSI86 ∈ { y, m } x CONFIG_PWM ∈ { y, m, n }.

There is no change until CONFIG_PWM actually becomes tristate.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>
Reviewed-by: Robert Foss <rfoss@kernel.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20250217174936.758420-2-u.kleine-koenig@baylibre.com

authored by

Uwe Kleine-König and committed by
Douglas Anderson ed531fed 27d48151

+3 -3
+3 -3
drivers/gpu/drm/bridge/ti-sn65dsi86.c
··· 195 195 struct gpio_chip gchip; 196 196 DECLARE_BITMAP(gchip_output, SN_NUM_GPIOS); 197 197 #endif 198 - #if defined(CONFIG_PWM) 198 + #if IS_REACHABLE(CONFIG_PWM) 199 199 struct pwm_chip *pchip; 200 200 bool pwm_enabled; 201 201 atomic_t pwm_pin_busy; ··· 1362 1362 /* ----------------------------------------------------------------------------- 1363 1363 * PWM Controller 1364 1364 */ 1365 - #if defined(CONFIG_PWM) 1365 + #if IS_REACHABLE(CONFIG_PWM) 1366 1366 static int ti_sn_pwm_pin_request(struct ti_sn65dsi86 *pdata) 1367 1367 { 1368 1368 return atomic_xchg(&pdata->pwm_pin_busy, 1) ? -EBUSY : 0; ··· 1956 1956 return ret; 1957 1957 } 1958 1958 1959 - if (IS_ENABLED(CONFIG_PWM)) { 1959 + if (IS_REACHABLE(CONFIG_PWM)) { 1960 1960 ret = ti_sn65dsi86_add_aux_device(pdata, &pdata->pwm_aux, "pwm"); 1961 1961 if (ret) 1962 1962 return ret;