tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

kconfig: Update config changed flag before calling callback

Prior to commit 5ee546594025 ("kconfig: change sym_change_count to a
boolean flag"), the conf_updated flag was set to the new value *before*
calling the callback. xconfig's save action depends on this behaviour,
because xconfig calls conf_get_changed() directly from the callback and
now sees the old value, thus never enabling the save button or the
shortcut.

Restore the previous behaviour.

Fixes: 5ee546594025 ("kconfig: change sym_change_count to a boolean flag")
Signed-off-by: Jurica Vukadin <jura@vukad.in>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

authored by

Jurica Vukadin and committed by
Masahiro Yamada ee06a3ef ced0f245

+4 -2
+4 -2
scripts/kconfig/confdata.c
··· 1226 1226 1227 1227 void conf_set_changed(bool val) 1228 1228 { 1229 - if (conf_changed_callback && conf_changed != val) 1230 - conf_changed_callback(); 1229 + bool changed = conf_changed != val; 1231 1230 1232 1231 conf_changed = val; 1232 + 1233 + if (conf_changed_callback && changed) 1234 + conf_changed_callback(); 1233 1235 } 1234 1236 1235 1237 bool conf_get_changed(void)