tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

sparc/crc: drop "glue" from filenames

The use of the term "glue" in filenames is a Crypto API-ism that rarely
shows up elsewhere in lib/ or arch/*/lib/. I think adopting it there
was a mistake. The library just uses standard functions, so the amount
of code that could be considered "glue" is quite small. And while often
the C functions just wrap the assembly functions, there are also cases
like crc32c_arch() in arch/x86/lib/crc32-glue.c that blur the line by
in-lining the actual implementation into the C function. That's not
"glue code", but rather the actual code.

Therefore, let's drop "glue" from the filenames and instead use e.g.
crc32.c instead of crc32-glue.c.

Reviewed-by: "Martin K. Petersen" <martin.petersen@oracle.com>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
Link: https://lore.kernel.org/r/20250424002038.179114-7-ebiggers@kernel.org
Signed-off-by: Eric Biggers <ebiggers@google.com>

Eric Biggers ee858d83 fa7ed85c

+2 -2
+1 -1
arch/sparc/lib/Makefile
··· 54 54 obj-$(CONFIG_SPARC32) += atomic32.o 55 55 obj-$(CONFIG_SPARC64) += PeeCeeI.o 56 56 obj-$(CONFIG_CRC32_ARCH) += crc32-sparc.o 57 - crc32-sparc-y := crc32_glue.o crc32c_asm.o 57 + crc32-sparc-y := crc32.o crc32c_asm.o
+1 -1
arch/sparc/lib/crc32_glue.c arch/sparc/lib/crc32.c
··· 1 1 // SPDX-License-Identifier: GPL-2.0-only 2 - /* Glue code for CRC32C optimized for sparc64 crypto opcodes. 2 + /* CRC32c (Castagnoli), sparc64 crc32c opcode accelerated 3 3 * 4 4 * This is based largely upon arch/x86/crypto/crc32c-intel.c 5 5 *