tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

ALSA: hda/tas2781: Fix the ld issue reported by kernel test robot

After commit 9fa6a693ad8d ("ALSA: hda/tas2781: Remove tas2781_spi_fwlib.c
and leverage SND_SOC_TAS2781_FMWLIB")created a separated lib for i2c,
However, tasdevice_remove() used for not only for I2C but for SPI being
still in that lib caused ld issue.
All errors (new ones prefixed by >>):
>> ld.lld: error: undefined symbol: tasdevice_remove
>>> referenced by tas2781_hda.c:33 (sound/pci/hda/tas2781_hda.c:33)
>>> vmlinux.o:(tas2781_hda_remove)
To fix this issue, the implementation of tasdevice_remove was moved from
tas2781-comlib-i2c.c to tas2781-comlib.c.

Fixes: 9fa6a693ad8d ("ALSA: hda/tas2781: Remove tas2781_spi_fwlib.c and leverage SND_SOC_TAS2781_FMWLIB")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://urldefense.com/v3/__https://lore.kernel.org/oe-kbuild-all/202505111855.FP2fScKA-lkp@intel.com/__;!!G3vK!U-wdsvrOG1iezggZ55RYi8ikBxMaJD
Signed-off-by: Shenghao Ding <shenghao-ding@ti.com>
Link: https://patch.msgid.link/20250513085947.1121-1-shenghao-ding@ti.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>

authored by

Shenghao Ding and committed by
Takashi Iwai eef5bccf 6f174dae

+6 -6
-6
sound/soc/codecs/tas2781-comlib-i2c.c
··· 364 364 } 365 365 EXPORT_SYMBOL_GPL(tascodec_init); 366 366 367 - void tasdevice_remove(struct tasdevice_priv *tas_priv) 368 - { 369 - mutex_destroy(&tas_priv->codec_lock); 370 - } 371 - EXPORT_SYMBOL_GPL(tasdevice_remove); 372 - 373 367 MODULE_DESCRIPTION("TAS2781 common library for I2C"); 374 368 MODULE_AUTHOR("Shenghao Ding, TI, <shenghao-ding@ti.com>"); 375 369 MODULE_LICENSE("GPL");
+6
sound/soc/codecs/tas2781-comlib.c
··· 225 225 } 226 226 EXPORT_SYMBOL_GPL(tasdevice_dsp_remove); 227 227 228 + void tasdevice_remove(struct tasdevice_priv *tas_priv) 229 + { 230 + mutex_destroy(&tas_priv->codec_lock); 231 + } 232 + EXPORT_SYMBOL_GPL(tasdevice_remove); 233 + 228 234 MODULE_DESCRIPTION("TAS2781 common library"); 229 235 MODULE_AUTHOR("Shenghao Ding, TI, <shenghao-ding@ti.com>"); 230 236 MODULE_LICENSE("GPL");