tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

net: dsa: tag_brcm: legacy: fix pskb_may_pull length

BRCM_LEG_PORT_ID was incorrectly used for pskb_may_pull length.
The correct check is BRCM_LEG_TAG_LEN + VLAN_HLEN, or 10 bytes.

Fixes: 964dbf186eaa ("net: dsa: tag_brcm: add support for legacy tags")
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Link: https://patch.msgid.link/20250529124406.2513779-1-noltari@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Álvaro Fernández Rojas and committed by
Jakub Kicinski efdddc44 d1a866d5

+1 -1
+1 -1
net/dsa/tag_brcm.c
··· 257 257 int source_port; 258 258 u8 *brcm_tag; 259 259 260 - if (unlikely(!pskb_may_pull(skb, BRCM_LEG_PORT_ID))) 260 + if (unlikely(!pskb_may_pull(skb, BRCM_LEG_TAG_LEN + VLAN_HLEN))) 261 261 return NULL; 262 262 263 263 brcm_tag = dsa_etype_header_pos_rx(skb);