tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

scsi: target: Simplify target_lu_gp_members_show()

Remove the stack buffer 'buf'. This patch does not modify the output
produced by target_lu_gp_members_show().

An example of the output that is produced with this patch applied:

$ cat /sys/kernel/config/target/core/alua/lu_gps/default_lu_gp/members
fileio_0/vdev0
fileio_1/vdev1
iblock_0/vdev2
$ od -c /sys/kernel/config/target/core/alua/lu_gps/default_lu_gp/members
0000000 f i l e i o _ 0 / v d e v 0 \n f
0000020 i l e i o _ 1 / v d e v 1 \n i b
0000040 l o c k _ 0 / v d e v 2 \n
0000055

Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://patch.msgid.link/20251027184639.3501254-3-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

authored by

Bart Van Assche and committed by
Martin K. Petersen f010c39a c03b55f2

+7 -15
+7 -15
drivers/target/target_core_configfs.c
··· 2773 2773 static ssize_t target_lu_gp_members_show(struct config_item *item, char *page) 2774 2774 { 2775 2775 struct t10_alua_lu_gp *lu_gp = to_lu_gp(item); 2776 - struct se_device *dev; 2777 - struct se_hba *hba; 2778 2776 struct t10_alua_lu_gp_member *lu_gp_mem; 2779 - ssize_t len = 0, cur_len; 2780 - unsigned char buf[LU_GROUP_NAME_BUF] = { }; 2777 + const char *const end = page + PAGE_SIZE; 2778 + char *cur = page; 2781 2779 2782 2780 spin_lock(&lu_gp->lu_gp_lock); 2783 2781 list_for_each_entry(lu_gp_mem, &lu_gp->lu_gp_mem_list, lu_gp_mem_list) { 2784 - dev = lu_gp_mem->lu_gp_mem_dev; 2785 - hba = dev->se_hba; 2782 + struct se_device *dev = lu_gp_mem->lu_gp_mem_dev; 2783 + struct se_hba *hba = dev->se_hba; 2786 2784 2787 - cur_len = snprintf(buf, LU_GROUP_NAME_BUF, "%s/%s\n", 2785 + cur += scnprintf(cur, end - cur, "%s/%s\n", 2788 2786 config_item_name(&hba->hba_group.cg_item), 2789 2787 config_item_name(&dev->dev_group.cg_item)); 2790 - 2791 - if ((cur_len + len) > PAGE_SIZE || cur_len > LU_GROUP_NAME_BUF) { 2792 - pr_warn("Ran out of lu_gp_show_attr" 2793 - "_members buffer\n"); 2788 + if (WARN_ON_ONCE(cur >= end)) 2794 2789 break; 2795 - } 2796 - memcpy(page+len, buf, cur_len); 2797 - len += cur_len; 2798 2790 } 2799 2791 spin_unlock(&lu_gp->lu_gp_lock); 2800 2792 2801 - return len; 2793 + return cur - page; 2802 2794 } 2803 2795 2804 2796 CONFIGFS_ATTR(target_lu_gp_, lu_gp_id);