tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

net: wwan: iosm: use int type to store negative error codes

The 'ret' variable in ipc_pcie_resources_request() either stores '-EBUSY'
directly or holds returns from pci_request_regions() and ipc_acquire_irq().
Storing negative error codes in u32 causes no runtime issues but is
stylistically inconsistent and very ugly. Change 'ret' from u32 to int
type - this has no runtime impact.

Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Reviewed-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
Link: https://patch.msgid.link/20250826135021.510767-1-rongqianfeng@vivo.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Qianfeng Rong and committed by
Jakub Kicinski f0c88a0d 6aff3699

+1 -1
+1 -1
drivers/net/wwan/iosm/iosm_ipc_pcie.c
··· 69 69 { 70 70 struct pci_dev *pci = ipc_pcie->pci; 71 71 u32 cap = 0; 72 - u32 ret; 72 + int ret; 73 73 74 74 /* Reserved PCI I/O and memory resources. 75 75 * Mark all PCI regions associated with PCI device pci as