tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

pds_fwctl: Remove the use of dev_err_probe()

Logging messages that show some type of "out of memory" error are generally
unnecessary as there is a generic message and a stack dump done by the
memory subsystem. These messages generally increase kernel size without
much added value[1].

The dev_err_probe() doesn't do anything when error is '-ENOMEM'. Therefore,
remove the useless call to dev_err_probe(), and just return the value
instead.

[1]: https://lore.kernel.org/lkml/1402419340.30479.18.camel@joe-AO725/

Link: https://patch.msgid.link/r/20250820124011.474224-1-liaoyuanhong@vivo.com
Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
Reviewed-by: Brett Creeley <brett.creeley@amd.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>

authored by

Liao Yuanhong and committed by
Jason Gunthorpe f1234301 7f059e47

+1 -1
+1 -1
drivers/fwctl/pds/main.c
··· 481 481 pdsfc = fwctl_alloc_device(&padev->vf_pdev->dev, &pdsfc_ops, 482 482 struct pdsfc_dev, fwctl); 483 483 if (!pdsfc) 484 - return dev_err_probe(dev, -ENOMEM, "Failed to allocate fwctl device struct\n"); 484 + return -ENOMEM; 485 485 pdsfc->padev = padev; 486 486 487 487 err = pdsfc_identify(pdsfc);