tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

drm/rockchip: Demote normal drm_err to debug

A plane check failing is a normal and expected condition, as userspace
isn't aware of the specific constraints and will try any and every
combination until one succeeds. Push this down to a debug message, so
users can see it if they want to, but make sure we don't spam the log
during normal operation.

Fixes: 604be85547ce4 ("drm/rockchip: Add VOP2 driver")
Signed-off-by: Daniel Stone <daniels@collabora.com>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://lore.kernel.org/r/20251015110042.41273-2-daniels@collabora.com

authored by

Daniel Stone and committed by
Heiko Stuebner f233921d 4f5f8baf

+9 -9
+9 -9
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
··· 1032 1032 1033 1033 if (drm_rect_width(src) >> 16 < 4 || drm_rect_height(src) >> 16 < 4 || 1034 1034 drm_rect_width(dest) < 4 || drm_rect_width(dest) < 4) { 1035 - drm_err(vop2->drm, "Invalid size: %dx%d->%dx%d, min size is 4x4\n", 1036 - drm_rect_width(src) >> 16, drm_rect_height(src) >> 16, 1037 - drm_rect_width(dest), drm_rect_height(dest)); 1035 + drm_dbg_kms(vop2->drm, "Invalid size: %dx%d->%dx%d, min size is 4x4\n", 1036 + drm_rect_width(src) >> 16, drm_rect_height(src) >> 16, 1037 + drm_rect_width(dest), drm_rect_height(dest)); 1038 1038 pstate->visible = false; 1039 1039 return 0; 1040 1040 } 1041 1041 1042 1042 if (drm_rect_width(src) >> 16 > vop2_data->max_input.width || 1043 1043 drm_rect_height(src) >> 16 > vop2_data->max_input.height) { 1044 - drm_err(vop2->drm, "Invalid source: %dx%d. max input: %dx%d\n", 1045 - drm_rect_width(src) >> 16, 1046 - drm_rect_height(src) >> 16, 1047 - vop2_data->max_input.width, 1048 - vop2_data->max_input.height); 1044 + drm_dbg_kms(vop2->drm, "Invalid source: %dx%d. max input: %dx%d\n", 1045 + drm_rect_width(src) >> 16, 1046 + drm_rect_height(src) >> 16, 1047 + vop2_data->max_input.width, 1048 + vop2_data->max_input.height); 1049 1049 return -EINVAL; 1050 1050 } 1051 1051 ··· 1054 1054 * need align with 2 pixel. 1055 1055 */ 1056 1056 if (fb->format->is_yuv && ((pstate->src.x1 >> 16) % 2)) { 1057 - drm_err(vop2->drm, "Invalid Source: Yuv format not support odd xpos\n"); 1057 + drm_dbg_kms(vop2->drm, "Invalid Source: Yuv format not support odd xpos\n"); 1058 1058 return -EINVAL; 1059 1059 } 1060 1060