tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

drm/amd/display: Fix parameter mismatch in panel self-refresh helper

Align parameter names with function arguments.

The function controls panel self-refresh enable/disable based on vblank
and VRR state.

Fixes the below with gcc W=1:
../display/amdgpu_dm/amdgpu_dm_crtc.c:131 function parameter 'dm' not described in 'amdgpu_dm_crtc_set_panel_sr_feature'
../display/amdgpu_dm/amdgpu_dm_crtc.c:131 function parameter 'acrtc' not described in 'amdgpu_dm_crtc_set_panel_sr_feature'
../display/amdgpu_dm/amdgpu_dm_crtc.c:131 function parameter 'stream' not described in 'amdgpu_dm_crtc_set_panel_sr_feature'
../display/amdgpu_dm/amdgpu_dm_crtc.c:131 function parameter 'dm' not described in 'amdgpu_dm_crtc_set_panel_sr_feature'
../display/amdgpu_dm/amdgpu_dm_crtc.c:131 function parameter 'acrtc' not described in 'amdgpu_dm_crtc_set_panel_sr_feature'
../display/amdgpu_dm/amdgpu_dm_crtc.c:131 function parameter 'stream' not described in 'amdgpu_dm_crtc_set_panel_sr_feature'

Fixes: 754003486c3c ("drm/amd/display: Add Idle state manager(ISM)")
Cc: Ray Wu <ray.wu@amd.com>
Cc: Leo Li <sunpeng.li@amd.com>
Cc: Roman Li <roman.li@amd.com>
Cc: Alex Hung <alex.hung@amd.com>
Cc: Tom Chung <chiahsuan.chung@amd.com>
Cc: Aurabindo Pillai <aurabindo.pillai@amd.com>
Cc: Mario Limonciello (AMD) <superm1@kernel.org>
Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Reviewed-by: Alex Hung <alex.hung@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

authored by

Srinivasan Shanmugam and committed by
Alex Deucher f2483b3f bf3fc94c

+10 -11
+10 -11
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c
··· 101 101 102 102 /** 103 103 * amdgpu_dm_crtc_set_panel_sr_feature() - Manage panel self-refresh features. 104 - * 105 - * @vblank_work: is a pointer to a struct vblank_control_work object. 106 - * @vblank_enabled: indicates whether the DRM vblank counter is currently 107 - * enabled (true) or disabled (false). 108 - * @allow_sr_entry: represents whether entry into the self-refresh mode is 109 - * allowed (true) or not allowed (false). 104 + * @dm: amdgpu display manager instance. 105 + * @acrtc: CRTC whose panel self-refresh state is being updated. 106 + * @stream: DC stream associated with @acrtc. 107 + * @vblank_enabled: Whether the DRM vblank counter is currently enabled. 108 + * @allow_sr_entry: Whether entry into self-refresh mode is allowed. 110 109 * 111 110 * The DRM vblank counter enable/disable action is used as the trigger to enable 112 111 * or disable various panel self-refresh features: 113 112 * 114 113 * Panel Replay and PSR SU 115 114 * - Enable when: 116 - * - VRR is disabled 117 - * - vblank counter is disabled 118 - * - entry is allowed: usermode demonstrates an adequate number of fast 119 - * commits) 120 - * - CRC capture window isn't active 115 + * - VRR is disabled 116 + * - vblank counter is disabled 117 + * - entry is allowed: usermode demonstrates an adequate number of fast 118 + * commits 119 + * - CRC capture window isn't active 121 120 * - Keep enabled even when vblank counter gets enabled 122 121 * 123 122 * PSR1