Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
phy: phy-rockchip-samsung-hdptx: Don't request RST_PHY/RST_ROPLL/RST_LCPLL
RST_PHY/RST_ROPLL/RST_LCPLL are used for debug only on rk3588,
and they are not exported on rk3576, no need to request it in
driver.
Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
Link: https://lore.kernel.org/r/20240920093629.7410-1-andyshrk@163.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
authored by
Andy Yan
and committed by
Vinod Koul
f2dbca16
c9be539e
+1
-16
+1
-16
drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c
+1
-16
drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c
···
256
256
};
257
257
258
258
enum rk_hdptx_reset {
259
-
RST_PHY = 0,
260
-
RST_APB,
259
+
RST_APB = 0,
261
260
RST_INIT,
262
261
RST_CMN,
263
262
RST_LANE,
264
-
RST_ROPLL,
265
-
RST_LCPLL,
266
263
RST_MAX
267
264
};
268
265
···
662
665
{
663
666
u32 val;
664
667
665
-
/* reset phy and apb, or phy locked flag may keep 1 */
666
-
reset_control_assert(hdptx->rsts[RST_PHY].rstc);
667
-
usleep_range(20, 30);
668
-
reset_control_deassert(hdptx->rsts[RST_PHY].rstc);
669
-
670
668
reset_control_assert(hdptx->rsts[RST_APB].rstc);
671
669
usleep_range(20, 30);
672
670
reset_control_deassert(hdptx->rsts[RST_APB].rstc);
···
783
791
cfg->sdm_num_sign, cfg->sdm_num, cfg->sdm_deno);
784
792
785
793
rk_hdptx_pre_power_up(hdptx);
786
-
787
-
reset_control_assert(hdptx->rsts[RST_ROPLL].rstc);
788
-
usleep_range(20, 30);
789
-
reset_control_deassert(hdptx->rsts[RST_ROPLL].rstc);
790
794
791
795
rk_hdptx_multi_reg_write(hdptx, rk_hdtpx_common_cmn_init_seq);
792
796
rk_hdptx_multi_reg_write(hdptx, rk_hdtpx_tmds_cmn_init_seq);
···
1086
1098
return dev_err_probe(dev, PTR_ERR(hdptx->regmap),
1087
1099
"Failed to init regmap\n");
1088
1100
1089
-
hdptx->rsts[RST_PHY].id = "phy";
1090
1101
hdptx->rsts[RST_APB].id = "apb";
1091
1102
hdptx->rsts[RST_INIT].id = "init";
1092
1103
hdptx->rsts[RST_CMN].id = "cmn";
1093
1104
hdptx->rsts[RST_LANE].id = "lane";
1094
-
hdptx->rsts[RST_ROPLL].id = "ropll";
1095
-
hdptx->rsts[RST_LCPLL].id = "lcpll";
1096
1105
1097
1106
ret = devm_reset_control_bulk_get_exclusive(dev, RST_MAX, hdptx->rsts);
1098
1107
if (ret)