Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

workqueue: Use POOL_BH instead of WQ_BH when checking pool flags

pr_cont_worker_id() checks pool->flags against WQ_BH, which is a
workqueue-level flag (defined in workqueue.h). Pool flags use a
separate namespace with POOL_* constants (defined in workqueue.c).
The correct constant is POOL_BH. Both WQ_BH and POOL_BH are defined
as (1 << 0) so this has no behavioral impact, but it is semantically
wrong and inconsistent with every other pool-level BH check in the
file.

Fixes: 4cb1ef64609f ("workqueue: Implement BH workqueues to eventually replace tasklets")
Signed-off-by: Breno Leitao <leitao@debian.org>
Acked-by: Song Liu <song@kernel.org>
Signed-off-by: Tejun Heo <tj@kernel.org>

authored by

Breno Leitao and committed by
Tejun Heo
f42f9091 c107785c

+1 -1
+1 -1
kernel/workqueue.c
··· 6274 6274 { 6275 6275 struct worker_pool *pool = worker->pool; 6276 6276 6277 - if (pool->flags & WQ_BH) 6277 + if (pool->flags & POOL_BH) 6278 6278 pr_cont("bh%s", 6279 6279 pool->attrs->nice == HIGHPRI_NICE_LEVEL ? "-hi" : ""); 6280 6280 else