tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

drm/panel: JDI LT070ME05000 simplify with dev_err_probe()

Use the dev_err_probe() helper to simplify error handling during probe.
This also handle scenario, when EDEFER is returned and useless error is printed.

Fixes error:
panel-jdi-lt070me05000 4700000.dsi.0: cannot get enable-gpio -517

Signed-off-by: David Heidelberg <david@ixit.cz>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230812185239.378582-1-david@ixit.cz

authored by

David Heidelberg and committed by
Neil Armstrong f5d8f9c0 d19859a0

+14 -22
+14 -22
drivers/gpu/drm/panel/panel-jdi-lt070me05000.c
··· 400 400 401 401 ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(jdi->supplies), 402 402 jdi->supplies); 403 - if (ret < 0) { 404 - dev_err(dev, "failed to init regulator, ret=%d\n", ret); 405 - return ret; 406 - } 403 + if (ret < 0) 404 + return dev_err_probe(dev, ret, 405 + "failed to init regulator, ret=%d\n", ret); 407 406 408 407 jdi->enable_gpio = devm_gpiod_get(dev, "enable", GPIOD_OUT_LOW); 409 408 if (IS_ERR(jdi->enable_gpio)) { 410 - ret = PTR_ERR(jdi->enable_gpio); 411 - dev_err(dev, "cannot get enable-gpio %d\n", ret); 412 - return ret; 409 + return dev_err_probe(dev, PTR_ERR(jdi->enable_gpio), 410 + "cannot get enable-gpio %d\n", ret); 413 411 } 414 412 415 413 jdi->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH); 416 - if (IS_ERR(jdi->reset_gpio)) { 417 - ret = PTR_ERR(jdi->reset_gpio); 418 - dev_err(dev, "cannot get reset-gpios %d\n", ret); 419 - return ret; 420 - } 414 + if (IS_ERR(jdi->reset_gpio)) 415 + return dev_err_probe(dev, PTR_ERR(jdi->reset_gpio), 416 + "cannot get reset-gpios %d\n", ret); 421 417 422 418 jdi->dcdc_en_gpio = devm_gpiod_get(dev, "dcdc-en", GPIOD_OUT_LOW); 423 - if (IS_ERR(jdi->dcdc_en_gpio)) { 424 - ret = PTR_ERR(jdi->dcdc_en_gpio); 425 - dev_err(dev, "cannot get dcdc-en-gpio %d\n", ret); 426 - return ret; 427 - } 419 + if (IS_ERR(jdi->dcdc_en_gpio)) 420 + return dev_err_probe(dev, PTR_ERR(jdi->dcdc_en_gpio), 421 + "cannot get dcdc-en-gpio %d\n", ret); 428 422 429 423 jdi->backlight = drm_panel_create_dsi_backlight(jdi->dsi); 430 - if (IS_ERR(jdi->backlight)) { 431 - ret = PTR_ERR(jdi->backlight); 432 - dev_err(dev, "failed to register backlight %d\n", ret); 433 - return ret; 434 - } 424 + if (IS_ERR(jdi->backlight)) 425 + return dev_err_probe(dev, PTR_ERR(jdi->backlight), 426 + "failed to register backlight %d\n", ret); 435 427 436 428 drm_panel_init(&jdi->base, &jdi->dsi->dev, &jdi_panel_funcs, 437 429 DRM_MODE_CONNECTOR_DSI);