tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Revert "drm/amdgpu/display: set vblank_disable_immediate for DC"

This reverts commit 92020e81ddbeac351ea4a19bcf01743f32b9c800.

This causes stuttering and timeouts with DMCUB for some users
so revert it until we understand why and safely enable it
to save power.

Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1887
Acked-by: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>

Alex Deucher f64e6e0b 50ef0cac

+1 -3
+1
drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
··· 320 320 if (!amdgpu_device_has_dc_support(adev)) { 321 321 if (!adev->enable_virtual_display) 322 322 /* Disable vblank IRQs aggressively for power-saving */ 323 + /* XXX: can this be enabled for DC? */ 323 324 adev_to_drm(adev)->vblank_disable_immediate = true; 324 325 325 326 r = drm_vblank_init(adev_to_drm(adev), adev->mode_info.num_crtc);
-3
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
··· 4251 4251 } 4252 4252 } 4253 4253 4254 - /* Disable vblank IRQs aggressively for power-saving. */ 4255 - adev_to_drm(adev)->vblank_disable_immediate = true; 4256 - 4257 4254 /* loops over all connectors on the board */ 4258 4255 for (i = 0; i < link_cnt; i++) { 4259 4256 struct dc_link *link = NULL;