Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

platform/x86: int0002: Remove IRQF_ONESHOT from request_irq()

Passing IRQF_ONESHOT ensures that the interrupt source is masked until the
secondary (threaded) handler is done. If only a primary handler is used
then the flag makes no sense because the interrupt cannot fire (again)
while its handler is running.

The flag also prevents force-threading of the primary handler and the
irq-core will warn about this.

The flag was added to match the flag on the shared handler which uses a
threaded handler and therefore IRQF_ONESHOT. This is no longer needed
because devm_request_irq() now passes IRQF_COND_ONESHOT for this case.

Revert adding IRQF_ONESHOT to irqflags.

Fixes: 8f812373d1958 ("platform/x86: intel: int0002_vgpio: Pass IRQF_ONESHOT to request_irq()")
Reported-by: Borah, Chaitanya Kumar <chaitanya.kumar.borah@intel.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Reviewed-by: Hans de Goede <johannes.goede@oss.qualcomm.com>
Acked-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://patch.msgid.link/20260128095540.863589-3-bigeasy@linutronix.de
Closes: https://lore.kernel.org/all/555f1c56-0f74-41bf-8bd2-6217e0aab0c6@intel.com

authored by

Sebastian Andrzej Siewior and committed by
Thomas Gleixner
f6bc7128 943b052d

+2 -2
+2 -2
drivers/platform/x86/intel/int0002_vgpio.c
··· 206 206 * FIXME: augment this if we managed to pull handling of shared 207 207 * IRQs into gpiolib. 208 208 */ 209 - ret = devm_request_irq(dev, irq, int0002_irq, 210 - IRQF_ONESHOT | IRQF_SHARED, "INT0002", chip); 209 + ret = devm_request_irq(dev, irq, int0002_irq, IRQF_SHARED, "INT0002", 210 + chip); 211 211 if (ret) { 212 212 dev_err(dev, "Error requesting IRQ %d: %d\n", irq, ret); 213 213 return ret;