tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Revert "8250: Fix tcsetattr to avoid ioctl(TIOCMIWAIT) hang"

This reverts commit 47d3904fe40d62deee8cd46e79ca784e7a548acd.

Crashes any x86 serial console bootup:

Console: colour VGA+ 80x25
BUG: unable to handle kernel NULL pointer dereference at 0000000000000158
IP: [<ffffffff811ebcb4>] serial8250_do_set_termios+0x1d4/0x430
...

Signed-off-by: Ingo Molnar <mingo@elte.hu>
Cc: Greg KH <gregkh@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Ingo Molnar and committed by
Linus Torvalds f8b372a1 c0caf7bc

+1 -4
+1 -4
drivers/serial/8250.c
··· 2343 2343 2344 2344 /* 2345 2345 * CTS flow control flag and modem status interrupts 2346 - * Only disable MSI if no threads are waiting in 2347 - * serial_core::uart_wait_modem_status 2348 2346 */ 2349 - if (!waitqueue_active(&up->port.state->port.delta_msr_wait)) 2350 - up->ier &= ~UART_IER_MSI; 2347 + up->ier &= ~UART_IER_MSI; 2351 2348 if (!(up->bugs & UART_BUG_NOMSR) && 2352 2349 UART_ENABLE_MS(&up->port, termios->c_cflag)) 2353 2350 up->ier |= UART_IER_MSI;