Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

posix-cpu-timers: fix race between handle_posix_cpu_timers() and posix_cpu_timer_del()

If an exiting non-autoreaping task has already passed exit_notify() and
calls handle_posix_cpu_timers() from IRQ, it can be reaped by its parent
or debugger right after unlock_task_sighand().

If a concurrent posix_cpu_timer_del() runs at that moment, it won't be
able to detect timer->it.cpu.firing != 0: cpu_timer_task_rcu() and/or
lock_task_sighand() will fail.

Add the tsk->exit_state check into run_posix_cpu_timers() to fix this.

This fix is not needed if CONFIG_POSIX_CPU_TIMERS_TASK_WORK=y, because
exit_task_work() is called before exit_notify(). But the check still
makes sense, task_work_add(&tsk->posix_cputimers_work.work) will fail
anyway in this case.

Cc: stable@vger.kernel.org
Reported-by: Benoît Sevens <bsevens@google.com>
Fixes: 0bdd2ed4138e ("sched: run_posix_cpu_timers: Don't check ->exit_state, use lock_task_sighand()")
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Oleg Nesterov and committed by
Linus Torvalds
f90fff1e 3ca933aa

+9
+9
kernel/time/posix-cpu-timers.c
··· 1406 1406 lockdep_assert_irqs_disabled(); 1407 1407 1408 1408 /* 1409 + * Ensure that release_task(tsk) can't happen while 1410 + * handle_posix_cpu_timers() is running. Otherwise, a concurrent 1411 + * posix_cpu_timer_del() may fail to lock_task_sighand(tsk) and 1412 + * miss timer->it.cpu.firing != 0. 1413 + */ 1414 + if (tsk->exit_state) 1415 + return; 1416 + 1417 + /* 1409 1418 * If the actual expiry is deferred to task work context and the 1410 1419 * work is already scheduled there is no point to do anything here. 1411 1420 */