tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Revert "venus: firmware: Correct non-pix start and end addresses"

This reverts commit a837e5161cff, which broke probing of the venus
driver, at least on the SC7180 SoC HP X2 Chromebook:

qcom-venus aa00000.video-codec: Adding to iommu group 11
qcom-venus aa00000.video-codec: non legacy binding
qcom-venus aa00000.video-codec: failed to reset venus core
qcom-venus: probe of aa00000.video-codec failed with error -110

Matthias Kaehlcke also reported that the same change caused a regression
in SC7180 and sc7280, that prevents AOSS from entering sleep mode during
system suspend. So let's revert this commit for now to fix both issues.

Fixes: a837e5161cff ("venus: firmware: Correct non-pix start and end addresses")
Reported-by: Matthias Kaehlcke <mka@chromium.org>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Javier Martinez Canillas and committed by
Linus Torvalds f95b8ea7 a10ca095

+2 -2
+2 -2
drivers/media/platform/qcom/venus/firmware.c
··· 38 38 writel(fw_size, wrapper_base + WRAPPER_FW_END_ADDR); 39 39 writel(0, wrapper_base + WRAPPER_CPA_START_ADDR); 40 40 writel(fw_size, wrapper_base + WRAPPER_CPA_END_ADDR); 41 - writel(0, wrapper_base + WRAPPER_NONPIX_START_ADDR); 42 - writel(0, wrapper_base + WRAPPER_NONPIX_END_ADDR); 41 + writel(fw_size, wrapper_base + WRAPPER_NONPIX_START_ADDR); 42 + writel(fw_size, wrapper_base + WRAPPER_NONPIX_END_ADDR); 43 43 44 44 if (IS_V6(core)) { 45 45 /* Bring XTSS out of reset */