tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

clk: qcom: clk-alpha-pll: drop lucid-evo pll enabled warning

The boot firmware may have left the display enabled and its PLL running,
which currently generates a warning on boot (e.g. on x1e80100):

disp_cc_pll0 PLL is already enabled

Drop the bogus warning and fix up the PLL enabled error handling
(trion_pll_is_enabled() only returns 0 or 1).

Fixes: d1b121d62b7e ("clk: qcom: Add LUCID_EVO PLL type for SDX65")
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Link: https://lore.kernel.org/r/20241022080521.359-2-johan+linaro@kernel.org
Signed-off-by: Bjorn Andersson <andersson@kernel.org>

authored by

Johan Hovold and committed by
Bjorn Andersson f9b493de 36d20224

+1 -6
+1 -6
drivers/clk/qcom/clk-alpha-pll.c
··· 2318 2318 } 2319 2319 2320 2320 /* Check if PLL is already enabled */ 2321 - ret = trion_pll_is_enabled(pll, regmap); 2322 - if (ret < 0) { 2323 - return ret; 2324 - } else if (ret) { 2325 - pr_warn("%s PLL is already enabled\n", clk_hw_get_name(&pll->clkr.hw)); 2321 + if (trion_pll_is_enabled(pll, regmap)) 2326 2322 return 0; 2327 - } 2328 2323 2329 2324 ret = regmap_update_bits(regmap, PLL_MODE(pll), PLL_RESET_N, PLL_RESET_N); 2330 2325 if (ret)