tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

media: ov8865: Improve error logging when fwnode is not found

The ov8865 driver waits for the endpoint fwnode to show up in case this
fwnode is created by a bridge-driver.

It does this by returning -EPROBE_DEFER, but it does not use
dev_err_probe() so no reason for deferring gets registered.

After 30 seconds the kernel logs a warning that the probe is still
deferred, which looks like this:

[ 33.952061] i2c i2c-INT347A:00: deferred probe pending: (reason unknown)

Use dev_err_probe() when returning -EPROBE_DEFER to register the probe
deferral reason changing the error to:

deferred probe pending: waiting for fwnode graph endpoint

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>

authored by

Hans de Goede and committed by
Hans Verkuil fabb0595 826f6fd6

+2 -1
+2 -1
drivers/media/i2c/ov8865.c
··· 2991 2991 2992 2992 handle = fwnode_graph_get_next_endpoint(dev_fwnode(dev), NULL); 2993 2993 if (!handle) 2994 - return -EPROBE_DEFER; 2994 + return dev_err_probe(dev, -EPROBE_DEFER, 2995 + "waiting for fwnode graph endpoint\n"); 2995 2996 2996 2997 sensor->endpoint.bus_type = V4L2_MBUS_CSI2_DPHY; 2997 2998