tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Bluetooth: qca: don't disable power management for QCA6390

We unnecessarily fallthrough the case for QCA6390 when initializing the
device and hit the condition where - due to the lack of the enable-gpio
- we disable power management despite using the power sequencer. We don't
need to look for clocks on this model so it makes more sense to just
register the hci device and break the switch.

Reported-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Fixes: 9a15ce685706 ("Bluetooth: qca: use the power sequencer for QCA6390")
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Acked-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Tested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> # RB5
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

authored by

Bartosz Golaszewski and committed by
Luiz Augusto von Dentz fb5e4713 b96bac96

+7 -1
+7 -1
drivers/bluetooth/hci_qca.c
··· 2402 2402 "bluetooth"); 2403 2403 if (IS_ERR(qcadev->bt_power->pwrseq)) 2404 2404 return PTR_ERR(qcadev->bt_power->pwrseq); 2405 - fallthrough; 2405 + 2406 + err = hci_uart_register_device(&qcadev->serdev_hu, &qca_proto); 2407 + if (err) { 2408 + BT_ERR("qca6390 serdev registration failed"); 2409 + return err; 2410 + } 2411 + break; 2406 2412 2407 2413 default: 2408 2414 qcadev->bt_en = devm_gpiod_get_optional(&serdev->dev, "enable",