tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Input: goodix-berlin - add I2C support for Goodix Berlin Touchscreen IC

Add initial support for the new Goodix "Berlin" touchscreen ICs
over the I2C interface.

This initial driver is derived from the Goodix goodix_ts_berlin
available at [1] and [2] and only supports the GT9916 IC
present on the Qualcomm SM8550 MTP & QRD touch panel.

The current implementation only supports BerlinD, aka GT9916.

[1] https://github.com/goodix/goodix_ts_berlin
[2] https://git.codelinaro.org/clo/la/platform/vendor/opensource/touch-drivers

Reviewed-by: Jeff LaBundy <jeff@labundy.com>
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/r/20240129-topic-goodix-berlin-upstream-initial-v15-3-6f7d096c0a0a@linaro.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

authored by

Neil Armstrong and committed by
Dmitry Torokhov fba09e81 44362279

+90
+14
drivers/input/touchscreen/Kconfig
··· 419 419 config TOUCHSCREEN_GOODIX_BERLIN_CORE 420 420 tristate 421 421 422 + config TOUCHSCREEN_GOODIX_BERLIN_I2C 423 + tristate "Goodix Berlin I2C touchscreen" 424 + depends on I2C 425 + select REGMAP_I2C 426 + select TOUCHSCREEN_GOODIX_BERLIN_CORE 427 + help 428 + Say Y here if you have a Goodix Berlin IC connected to 429 + your system via I2C. 430 + 431 + If unsure, say N. 432 + 433 + To compile this driver as a module, choose M here: the 434 + module will be called goodix_berlin_i2c. 435 + 422 436 config TOUCHSCREEN_HIDEEP 423 437 tristate "HiDeep Touch IC" 424 438 depends on I2C
+1
drivers/input/touchscreen/Makefile
··· 48 48 obj-$(CONFIG_TOUCHSCREEN_FUJITSU) += fujitsu_ts.o 49 49 obj-$(CONFIG_TOUCHSCREEN_GOODIX) += goodix_ts.o 50 50 obj-$(CONFIG_TOUCHSCREEN_GOODIX_BERLIN_CORE) += goodix_berlin_core.o 51 + obj-$(CONFIG_TOUCHSCREEN_GOODIX_BERLIN_I2C) += goodix_berlin_i2c.o 51 52 obj-$(CONFIG_TOUCHSCREEN_HIDEEP) += hideep.o 52 53 obj-$(CONFIG_TOUCHSCREEN_HYNITRON_CSTXXX) += hynitron_cstxxx.o 53 54 obj-$(CONFIG_TOUCHSCREEN_ILI210X) += ili210x.o
+75
drivers/input/touchscreen/goodix_berlin_i2c.c
··· 1 + // SPDX-License-Identifier: GPL-2.0-or-later 2 + /* 3 + * Goodix Berlin Touchscreen Driver 4 + * 5 + * Copyright (C) 2020 - 2021 Goodix, Inc. 6 + * Copyright (C) 2023 Linaro Ltd. 7 + * 8 + * Based on goodix_ts_berlin driver. 9 + */ 10 + #include <linux/i2c.h> 11 + #include <linux/kernel.h> 12 + #include <linux/module.h> 13 + #include <linux/regmap.h> 14 + #include <linux/input.h> 15 + 16 + #include "goodix_berlin.h" 17 + 18 + #define I2C_MAX_TRANSFER_SIZE 256 19 + 20 + static const struct regmap_config goodix_berlin_i2c_regmap_conf = { 21 + .reg_bits = 32, 22 + .val_bits = 8, 23 + .max_raw_read = I2C_MAX_TRANSFER_SIZE, 24 + .max_raw_write = I2C_MAX_TRANSFER_SIZE, 25 + }; 26 + 27 + /* vendor & product left unassigned here, should probably be updated from fw info */ 28 + static const struct input_id goodix_berlin_i2c_input_id = { 29 + .bustype = BUS_I2C, 30 + }; 31 + 32 + static int goodix_berlin_i2c_probe(struct i2c_client *client) 33 + { 34 + struct regmap *regmap; 35 + int error; 36 + 37 + regmap = devm_regmap_init_i2c(client, &goodix_berlin_i2c_regmap_conf); 38 + if (IS_ERR(regmap)) 39 + return PTR_ERR(regmap); 40 + 41 + error = goodix_berlin_probe(&client->dev, client->irq, 42 + &goodix_berlin_i2c_input_id, regmap); 43 + if (error) 44 + return error; 45 + 46 + return 0; 47 + } 48 + 49 + static const struct i2c_device_id goodix_berlin_i2c_id[] = { 50 + { "gt9916", 0 }, 51 + { } 52 + }; 53 + 54 + MODULE_DEVICE_TABLE(i2c, goodix_berlin_i2c_id); 55 + 56 + static const struct of_device_id goodix_berlin_i2c_of_match[] = { 57 + { .compatible = "goodix,gt9916", }, 58 + { } 59 + }; 60 + MODULE_DEVICE_TABLE(of, goodix_berlin_i2c_of_match); 61 + 62 + static struct i2c_driver goodix_berlin_i2c_driver = { 63 + .driver = { 64 + .name = "goodix-berlin-i2c", 65 + .of_match_table = goodix_berlin_i2c_of_match, 66 + .pm = pm_sleep_ptr(&goodix_berlin_pm_ops), 67 + }, 68 + .probe = goodix_berlin_i2c_probe, 69 + .id_table = goodix_berlin_i2c_id, 70 + }; 71 + module_i2c_driver(goodix_berlin_i2c_driver); 72 + 73 + MODULE_LICENSE("GPL"); 74 + MODULE_DESCRIPTION("Goodix Berlin I2C Touchscreen driver"); 75 + MODULE_AUTHOR("Neil Armstrong <neil.armstrong@linaro.org>");