tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

eth: fbnic: fix `tx_dropped` counting

Fix the tracking of rtnl_link_stats.tx_dropped. The counter
`tmi.drop.frames` is being double counted whereas, the counter
`tti.cm_drop.frames` is being skipped.

Fixes: f2957147ae7a ("eth: fbnic: add support for TTI HW stats")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Mohsin Bashir <mohsin.bashr@gmail.com>
Reviewed-by: Joe Damato <jdamato@fastly.com>
Link: https://patch.msgid.link/20250503020145.1868252-1-mohsin.bashr@gmail.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>

authored by

Mohsin Bashir and committed by
Paolo Abeni fbaeb7b0 8f0ae193

+2 -2
+2 -2
drivers/net/ethernet/meta/fbnic/fbnic_netdev.c
··· 425 425 426 426 /* Record drops from Tx HW Datapath */ 427 427 tx_dropped += fbd->hw_stats.tmi.drop.frames.value + 428 + fbd->hw_stats.tti.cm_drop.frames.value + 428 429 fbd->hw_stats.tti.frame_drop.frames.value + 429 - fbd->hw_stats.tti.tbi_drop.frames.value + 430 - fbd->hw_stats.tmi.drop.frames.value; 430 + fbd->hw_stats.tti.tbi_drop.frames.value; 431 431 432 432 for (i = 0; i < fbn->num_tx_queues; i++) { 433 433 struct fbnic_ring *txr = fbn->tx[i];