tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

i3c: mipi-i3c-hci: Change interrupt status prints to dev_dbg()

Change interrupt status prints from local DBG() macro to dev_dbg() in
order to make it easier to enable them without needing to recompile code
with DEBUG defined.

While doing so, spell out the status register names as they are in the
specification to make it easier to differentiate between different
interrupt status registers.

Since dynamic debug prints can include the line number remove the "(in)"
and "(out)" markers from the PIO interrupt status prints.

Prefix the ring interrupt status print using "Ring %d" instead of "rh%d"
to make it uniform across all other prints showing the ring number.

Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Link: https://lore.kernel.org/r/20250827103009.243771-2-jarkko.nikula@linux.intel.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

authored by

Jarkko Nikula and committed by
Alexandre Belloni fc09ffd3 ec011151

+7 -5
+1 -1
drivers/i3c/master/mipi-i3c-hci/core.c
··· 553 553 554 554 val = reg_read(INTR_STATUS); 555 555 reg_write(INTR_STATUS, val); 556 - DBG("INTR_STATUS = %#x", val); 556 + dev_dbg(&hci->master.dev, "INTR_STATUS %#x", val); 557 557 558 558 if (val) 559 559 result = IRQ_HANDLED;
+2 -1
drivers/i3c/master/mipi-i3c-hci/dma.c
··· 760 760 761 761 rh = &rings->headers[i]; 762 762 status = rh_reg_read(INTR_STATUS); 763 - DBG("rh%d status: %#x", i, status); 763 + dev_dbg(&hci->master.dev, "Ring %d: RH_INTR_STATUS %#x", 764 + i, status); 764 765 if (!status) 765 766 continue; 766 767 rh_reg_write(INTR_STATUS, status);
+4 -3
drivers/i3c/master/mipi-i3c-hci/pio.c
··· 986 986 987 987 spin_lock(&pio->lock); 988 988 status = pio_reg_read(INTR_STATUS); 989 - DBG("(in) status: %#x/%#x", status, pio->enabled_irqs); 989 + dev_dbg(&hci->master.dev, "PIO_INTR_STATUS %#x/%#x", 990 + status, pio->enabled_irqs); 990 991 status &= pio->enabled_irqs | STAT_LATENCY_WARNINGS; 991 992 if (!status) { 992 993 spin_unlock(&pio->lock); ··· 1024 1023 pio->enabled_irqs &= ~STAT_CMD_QUEUE_READY; 1025 1024 1026 1025 pio_reg_write(INTR_SIGNAL_ENABLE, pio->enabled_irqs); 1027 - DBG("(out) status: %#x/%#x", 1028 - pio_reg_read(INTR_STATUS), pio_reg_read(INTR_SIGNAL_ENABLE)); 1026 + dev_dbg(&hci->master.dev, "PIO_INTR_STATUS %#x/%#x", 1027 + pio_reg_read(INTR_STATUS), pio_reg_read(INTR_SIGNAL_ENABLE)); 1029 1028 spin_unlock(&pio->lock); 1030 1029 return true; 1031 1030 }