tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

sh: Fix boot crash related to SCI

Commit d006199e72a9 ("serial: sh-sci: Regtype probing doesn't need to be
fatal.") made sci_init_single() return when sci_probe_regmap() succeeds,
although it should return when sci_probe_regmap() fails. This causes
systems using the serial sh-sci driver to crash during boot.

Fix the problem by using the right return condition.

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Rafael J. Wysocki and committed by
Linus Torvalds fc97114b f23c126b

+1 -1
+1 -1
drivers/tty/serial/sh-sci.c
··· 1889 1889 1890 1890 if (p->regtype == SCIx_PROBE_REGTYPE) { 1891 1891 ret = sci_probe_regmap(p); 1892 - if (unlikely(!ret)) 1892 + if (unlikely(ret)) 1893 1893 return ret; 1894 1894 } 1895 1895