tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

drm/amdgpu: add upper bound check on user inputs in wait ioctl

Huge input values in amdgpu_userq_wait_ioctl can lead to a OOM and
could be exploited.

So check these input value against AMDGPU_USERQ_MAX_HANDLES
which is big enough value for genuine use cases and could
potentially avoid OOM.

v2: squash in Srini's fix

Signed-off-by: Sunil Khatri <sunil.khatri@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

authored by

Sunil Khatri and committed by
Alex Deucher fcec012c be267e15

+5
+5
drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c
··· 635 635 if (!amdgpu_userq_enabled(dev)) 636 636 return -ENOTSUPP; 637 637 638 + if (wait_info->num_syncobj_handles > AMDGPU_USERQ_MAX_HANDLES || 639 + wait_info->num_bo_write_handles > AMDGPU_USERQ_MAX_HANDLES || 640 + wait_info->num_bo_read_handles > AMDGPU_USERQ_MAX_HANDLES) 641 + return -EINVAL; 642 + 638 643 num_syncobj = wait_info->num_syncobj_handles; 639 644 syncobj_handles = memdup_array_user(u64_to_user_ptr(wait_info->syncobj_handles), 640 645 num_syncobj, sizeof(u32));