tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

pinctrl: cirrus: cs42l43: Fix double-put in cs42l43_pin_probe()

devm_add_action_or_reset() already invokes the action on failure,
so the explicit put causes a double-put.

Fixes: 9b07cdf86a0b ("pinctrl: cirrus: Fix fwnode leak in cs42l43_pin_probe()")
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Linus Walleij <linusw@kernel.org>

authored by

Felix Gu and committed by
Linus Walleij fd5bed79 a2539b92

+2 -3
+2 -3
drivers/pinctrl/cirrus/pinctrl-cs42l43.c
··· 574 574 if (child) { 575 575 ret = devm_add_action_or_reset(&pdev->dev, 576 576 cs42l43_fwnode_put, child); 577 - if (ret) { 578 - fwnode_handle_put(child); 577 + if (ret) 579 578 return ret; 580 - } 579 + 581 580 if (!child->dev) 582 581 child->dev = priv->dev; 583 582 fwnode = child;