Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

cxl/edac: Fix the min_scrub_cycle of a region miscalculation

When trying to update the scrub_cycle value of a cxl region, which means
updating the scrub_cycle value of each memdev under a cxl region. cxl
driver needs to guarantee the new scrub_cycle value is greater than the
min_scrub_cycle value of a memdev, otherwise the updating operation will
fail(Per Table 8-223 in CXL r3.2 section 8.2.10.9.11.1).

Current implementation logic of getting the min_scrub_cycle value of a
cxl region is that getting the min_scrub_cycle value of each memdevs
under the cxl region, then using the minimum min_scrub_cycle value as
the region's min_scrub_cycle. Checking if the new scrub_cycle value is
greater than this value. If yes, updating the new scrub_cycle value to
each memdevs. The issue is that the new scrub_cycle value is possibly
greater than the minimum min_scrub_cycle value of all memdevs but less
than the maximum min_scrub_cycle value of all memdevs if memdevs have
a different min_scrub_cycle value. The updating operation will always
fail on these memdevs which have a greater min_scrub_cycle than the new
scrub_cycle.

The correct implementation logic is to get the maximum value of these
memdevs' min_scrub_cycle, check if the new scrub_cycle value is greater
than the value. If yes, the new scrub_cycle value is fit for the region.

The change also impacts the result of
cxl_patrol_scrub_get_min_scrub_cycle(), the interface returned the
minimum min_scrub_cycle value among all memdevs under the region before
the change. The interface will return the maximum min_scrub_cycle value
among all memdevs under the region with the change.

Signed-off-by: Li Ming <ming.li@zohomail.com>
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Reviewed-by: Shiju Jose <shiju.jose@huawei.com>
Reviewed-by: Davidlohr Bueso <dave@stgolabs.net>
Link: https://patch.msgid.link/20250603104314.25569-1-ming.li@zohomail.com
Signed-off-by: Dave Jiang <dave.jiang@intel.com>

authored by

Li Ming and committed by
Dave Jiang
fdc9be90 87b42c11

+6 -2
+6 -2
drivers/cxl/core/edac.c
··· 103 103 u8 *cap, u16 *cycle, u8 *flags, u8 *min_cycle) 104 104 { 105 105 struct cxl_mailbox *cxl_mbox; 106 - u8 min_scrub_cycle = U8_MAX; 107 106 struct cxl_region_params *p; 108 107 struct cxl_memdev *cxlmd; 109 108 struct cxl_region *cxlr; 109 + u8 min_scrub_cycle = 0; 110 110 int i, ret; 111 111 112 112 if (!cxl_ps_ctx->cxlr) { ··· 133 133 if (ret) 134 134 return ret; 135 135 136 + /* 137 + * The min_scrub_cycle of a region is the max of minimum scrub 138 + * cycles supported by memdevs that back the region. 139 + */ 136 140 if (min_cycle) 137 - min_scrub_cycle = min(*min_cycle, min_scrub_cycle); 141 + min_scrub_cycle = max(*min_cycle, min_scrub_cycle); 138 142 } 139 143 140 144 if (min_cycle)