tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

perf cs-etm: Remove unused stub methods

These aren't used outside of cs-etm so don't need stubs. Leave
cs_etm__process_auxtrace_info() which is used externally, and add an
error message so that it's obvious to users why it causes errors.

Signed-off-by: James Clark <james.clark@arm.com>
Cc: Al Grant <Al.Grant@arm.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: John Garry <john.g.garry@oracle.com>
Cc: Leo Yan <leo.yan@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Mike Leach <mike.leach@linaro.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Suzuki Poulouse <suzuki.poulose@arm.com>
Cc: Will Deacon <will@kernel.org>
Cc: coresight@lists.linaro.org
Cc: linux-arm-kernel@lists.infradead.org
Link: https://lore.kernel.org/r/20221212155513.2259623-3-james.clark@arm.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

authored by

James Clark and committed by
Arnaldo Carvalho de Melo fe55ba18 ab6bd55e

+2 -32
+2 -32
tools/perf/util/cs-etm.h
··· 7 7 #ifndef INCLUDE__UTIL_PERF_CS_ETM_H__ 8 8 #define INCLUDE__UTIL_PERF_CS_ETM_H__ 9 9 10 + #include "debug.h" 10 11 #include "util/event.h" 11 12 #include <linux/bits.h> 12 13 ··· 219 218 cs_etm__process_auxtrace_info(union perf_event *event __maybe_unused, 220 219 struct perf_session *session __maybe_unused) 221 220 { 221 + pr_err("\nCS ETM Trace: OpenCSD is not linked in, please recompile with CORESIGHT=1\n"); 222 222 return -1; 223 - } 224 - 225 - static inline int cs_etm__get_cpu(u8 trace_chan_id __maybe_unused, 226 - int *cpu __maybe_unused) 227 - { 228 - return -1; 229 - } 230 - 231 - static inline int cs_etm__etmq_set_tid( 232 - struct cs_etm_queue *etmq __maybe_unused, 233 - pid_t tid __maybe_unused, 234 - u8 trace_chan_id __maybe_unused) 235 - { 236 - return -1; 237 - } 238 - 239 - static inline bool cs_etm__etmq_is_timeless( 240 - struct cs_etm_queue *etmq __maybe_unused) 241 - { 242 - /* What else to return? */ 243 - return true; 244 - } 245 - 246 - static inline void cs_etm__etmq_set_traceid_queue_timestamp( 247 - struct cs_etm_queue *etmq __maybe_unused, 248 - u8 trace_chan_id __maybe_unused) {} 249 - 250 - static inline struct cs_etm_packet_queue *cs_etm__etmq_get_packet_queue( 251 - struct cs_etm_queue *etmq __maybe_unused, 252 - u8 trace_chan_id __maybe_unused) 253 - { 254 - return NULL; 255 223 } 256 224 #endif 257 225