tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

phy: qcom-qmp-pcie: fix initialisation reset

Add the missing delay after asserting reset. This is specifically needed
for the reset to have any effect on SC8280XP.

The vendor driver uses a 1 ms delay, but that seems a bit excessive.
Instead use a 200 us delay which appears to be more than enough and also
matches the UFS reset delay added by commit 870b1279c7a0 ("scsi:
ufs-qcom: Add reset control support for host controller").

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Link: https://lore.kernel.org/r/20221105145939.20318-14-johan+linaro@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>

authored by

Johan Hovold and committed by
Vinod Koul fffdeaf8 7bc609e3

+2
+2
drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
··· 1866 1866 goto err_disable_regulators; 1867 1867 } 1868 1868 1869 + usleep_range(200, 300); 1870 + 1869 1871 ret = reset_control_bulk_deassert(cfg->num_resets, qmp->resets); 1870 1872 if (ret) { 1871 1873 dev_err(qmp->dev, "reset deassert failed\n");