Mirror of @tangled.org/core. Running on a Raspberry Pi Zero 2 (Please be gentle).
0
fork

Configure Feed

Select the types of activity you want to include in your feed.

appview/gfi: render gfi label when there isn't any matching issues

although it might not happen, the appview should be able to handle when
there is no single issue with good-first-issue label

Signed-off-by: Seongmin Lee <git@boltless.me>

authored by

Seongmin Lee and committed by
Tangled
41091062 2e5a4cde

+9 -1
+9 -1
appview/state/gfi.go
··· 22 22 23 23 goodFirstIssueLabel := fmt.Sprintf("at://%s/%s/%s", consts.TangledDid, tangled.LabelDefinitionNSID, "good-first-issue") 24 24 25 + gfiLabelDef, err := db.GetLabelDefinition(s.db, db.FilterEq("at_uri", goodFirstIssueLabel)) 26 + if err != nil { 27 + log.Println("failed to get gfi label def", err) 28 + s.pages.Error500(w) 29 + return 30 + } 31 + 25 32 repoLabels, err := db.GetRepoLabels(s.db, db.FilterEq("label_at", goodFirstIssueLabel)) 26 33 if err != nil { 27 34 log.Println("failed to get repo labels", err) ··· 42 35 RepoGroups: []*models.RepoGroup{}, 43 36 LabelDefs: make(map[string]*models.LabelDefinition), 44 37 Page: page, 38 + GfiLabel: gfiLabelDef, 45 39 }) 46 40 return 47 41 } ··· 151 143 RepoGroups: paginatedGroups, 152 144 LabelDefs: labelDefsMap, 153 145 Page: page, 154 - GfiLabel: labelDefsMap[goodFirstIssueLabel], 146 + GfiLabel: gfiLabelDef, 155 147 }) 156 148 }