Mirror of @tangled.org/core. Running on a Raspberry Pi Zero 2 (Please be gentle).
0
fork

Configure Feed

Select the types of activity you want to include in your feed.

appview/db: close rows handles consistently

Signed-off-by: Thomas Karpiniec <tkarpiniec@icloud.com>

authored by

Thomas Karpiniec and committed by tangled.org ed258b1e ae0185bd

+22 -2
+2
appview/db/follow.go
··· 167 167 if err != nil { 168 168 return nil, err 169 169 } 170 + defer rows.Close() 171 + 170 172 for rows.Next() { 171 173 var follow models.Follow 172 174 var followedAt string
+1
appview/db/issues.go
··· 452 452 if err != nil { 453 453 return nil, err 454 454 } 455 + defer rows.Close() 455 456 456 457 for rows.Next() { 457 458 var comment models.IssueComment
+1 -1
appview/db/language.go
··· 28 28 whereClause, 29 29 ) 30 30 rows, err := e.Query(query, args...) 31 - 32 31 if err != nil { 33 32 return nil, fmt.Errorf("failed to execute query: %w ", err) 34 33 } 34 + defer rows.Close() 35 35 36 36 var langs []models.RepoLanguage 37 37 for rows.Next() {
+5
appview/db/profile.go
··· 230 230 if err != nil { 231 231 return nil, err 232 232 } 233 + defer rows.Close() 233 234 234 235 profileMap := make(map[string]*models.Profile) 235 236 for rows.Next() { ··· 271 270 if err != nil { 272 271 return nil, err 273 272 } 273 + defer rows.Close() 274 + 274 275 idxs := make(map[string]int) 275 276 for did := range profileMap { 276 277 idxs[did] = 0 ··· 293 290 if err != nil { 294 291 return nil, err 295 292 } 293 + defer rows.Close() 294 + 296 295 idxs = make(map[string]int) 297 296 for did := range profileMap { 298 297 idxs[did] = 0
+1
appview/db/registration.go
··· 38 38 if err != nil { 39 39 return nil, err 40 40 } 41 + defer rows.Close() 41 42 42 43 for rows.Next() { 43 44 var createdAt string
+11 -1
appview/db/repos.go
··· 56 56 limitClause, 57 57 ) 58 58 rows, err := e.Query(repoQuery, args...) 59 - 60 59 if err != nil { 61 60 return nil, fmt.Errorf("failed to execute repo query: %w ", err) 62 61 } 62 + defer rows.Close() 63 63 64 64 for rows.Next() { 65 65 var repo models.Repo ··· 128 128 if err != nil { 129 129 return nil, fmt.Errorf("failed to execute labels query: %w ", err) 130 130 } 131 + defer rows.Close() 132 + 131 133 for rows.Next() { 132 134 var repoat, labelat string 133 135 if err := rows.Scan(&repoat, &labelat); err != nil { ··· 167 165 if err != nil { 168 166 return nil, fmt.Errorf("failed to execute lang query: %w ", err) 169 167 } 168 + defer rows.Close() 169 + 170 170 for rows.Next() { 171 171 var repoat, lang string 172 172 if err := rows.Scan(&repoat, &lang); err != nil { ··· 195 191 if err != nil { 196 192 return nil, fmt.Errorf("failed to execute star-count query: %w ", err) 197 193 } 194 + defer rows.Close() 195 + 198 196 for rows.Next() { 199 197 var repoat string 200 198 var count int ··· 226 220 if err != nil { 227 221 return nil, fmt.Errorf("failed to execute issue-count query: %w ", err) 228 222 } 223 + defer rows.Close() 224 + 229 225 for rows.Next() { 230 226 var repoat string 231 227 var open, closed int ··· 269 261 if err != nil { 270 262 return nil, fmt.Errorf("failed to execute pulls-count query: %w ", err) 271 263 } 264 + defer rows.Close() 265 + 272 266 for rows.Next() { 273 267 var repoat string 274 268 var open, merged, closed, deleted int
+1
appview/db/star.go
··· 165 165 if err != nil { 166 166 return nil, err 167 167 } 168 + defer rows.Close() 168 169 169 170 starMap := make(map[string][]models.Star) 170 171 for rows.Next() {