Rockbox open source high quality audio player as a Music Player Daemon
mpris
rockbox
mpd
libadwaita
audio
rust
zig
deno
simplelist: fix unbalanced viewportmanager calls
viewportmanager_theme_enable isn't balanced by
viewportmanager_theme_undo when connecting to USB
while simplelist is displayed.
Change-Id: Iad9408a52150934246c886a01a5d1efc8febd0fd
+6
-6
+6
-6
apps/gui/list.c
+6
-6
apps/gui/list.c
···
585
585
*
586
586
* The GUI_EVENT_NEED_UI_UPDATE event is registered for in list_do_action_timeout()
587
587
* as a oneshot and current_lists updated. later current_lists is set to NULL
588
-
* in gui_synclist_do_button() effectively disabling the callback.
588
+
* in gui_synclist_do_button() effectively disabling the callback.
589
589
* This is done because if something is using the list UI they *must* be calling those
590
590
* two functions in the correct order or the list wont work.
591
591
*/
···
692
692
allow_wrap = false; /* Prevent list wraparound on repeating actions */
693
693
/*Fallthrough*/
694
694
case ACTION_STD_PREV:
695
-
695
+
696
696
gui_list_select_at_offset(lists, -next_item_modifier, allow_wrap);
697
697
#ifndef HAVE_WHEEL_ACCELERATION
698
698
if (button_queue_count() < FRAMEDROP_TRIGGER)
···
882
882
struct gui_synclist lists;
883
883
int action, old_line_count = simplelist_line_count;
884
884
list_get_name *getname;
885
-
int line_count;
885
+
int line_count, ret = false;
886
886
887
887
if (info->get_name)
888
888
{
···
971
971
}
972
972
else if(default_event_handler(action) == SYS_USB_CONNECTED)
973
973
{
974
-
gui_synclist_scroll_stop(&lists);
975
-
return true;
974
+
ret = true;
975
+
break;
976
976
}
977
977
}
978
978
talk_shutup();
···
986
986
987
987
FOR_NB_SCREENS(i)
988
988
viewportmanager_theme_undo(i, false);
989
-
return false;
989
+
return ret;
990
990
}
991
991
992
992
void simplelist_info_init(struct simplelist_info *info, char* title,