Rockbox open source high quality audio player as a Music Player Daemon
mpris
rockbox
mpd
libadwaita
audio
rust
zig
deno
mknkboot: optimize verifyfirm
The checksum only needs to be calculated once. A small oversight on
my initial implementation.
Change-Id: Ie23faf36f5add7ed7f146769b604dbd8204c2605
+8
-8
+8
-8
utils/MTP/beastpatcher/mknkboot.c
+8
-8
utils/MTP/beastpatcher/mknkboot.c
···
158
158
159
159
int verifyfirm(const struct filebuf* firmdata)
160
160
{
161
-
for(int i = 0; firmtable[i].version; i++)
162
-
{
163
-
md5_context ctx;
164
-
uint8_t sum[16];
161
+
md5_context ctx;
162
+
uint8_t sum[16];
165
163
166
-
md5_starts(&ctx);
167
-
md5_update(&ctx, firmdata->buf, firmdata->len);
168
-
md5_finish(&ctx, sum);
164
+
md5_starts(&ctx);
165
+
md5_update(&ctx, firmdata->buf, firmdata->len);
166
+
md5_finish(&ctx, sum);
169
167
170
-
if(memcmp(firmtable[i].sum, sum, 16) == 0)
168
+
for(int i = 0; firmtable[i].version; i++)
169
+
{
170
+
if(memcmp(firmtable[i].sum, sum, 16) == 0)
171
171
{
172
172
fprintf(stderr, "[INFO] Firmware file version %d.%d\n",
173
173
firmtable[i].version >> 8, firmtable[i].version & 0xff);