Rockbox open source high quality audio player as a Music Player Daemon
mpris rockbox mpd libadwaita audio rust zig deno
2
fork

Configure Feed

Select the types of activity you want to include in your feed.

asap codec: remove invalid memset

This would zero the first 4 or 8 bytes of the array because it is declared as a pointer

rockbox/lib/rbcodec/codecs/libasap/asap.c:1229:44: warning: argument to 'sizeof' in 'memset' call is the same expression as the destination; did you mean to provide an explicit length? [-Wsizeof-pointer-memaccess]
memset(ast -> memory, 0, sizeof(ast -> memory));
~~~~~~~~~~~~~ ~~~~~~~^~~~~~

-1
-1
lib/rbcodec/codecs/libasap/asap.c
··· 1226 1226 return FALSE; 1227 1227 if (ast == NULL) 1228 1228 return TRUE; 1229 - ZERO_ARRAY(ast _ memory); 1230 1229 module_index = module_info _ header_len + 2; 1231 1230 while (module_index + 5 <= module_len) { 1232 1231 V(int, start_addr) = UWORD(module, module_index);