Rockbox open source high quality audio player as a Music Player Daemon
mpris rockbox mpd libadwaita audio rust zig deno
2
fork

Configure Feed

Select the types of activity you want to include in your feed.

plugins: Remove id3 lib

only remaining user is PictureFlow, and
function is arguably not lib-worthy at
this point

Change-Id: If5cff56fc4aed7c8029782a7087ba4cfef3ec4ea

+18 -68
-2
apps/plugins/lib/SOURCES
··· 70 70 pluginlib_touchscreen.c 71 71 #endif 72 72 73 - id3.c 74 - 75 73 mul_id3.c
-39
apps/plugins/lib/id3.c
··· 1 - /*************************************************************************** 2 - * __________ __ ___. 3 - * Open \______ \ ____ ____ | | _\_ |__ _______ ___ 4 - * Source | _// _ \_/ ___\| |/ /| __ \ / _ \ \/ / 5 - * Jukebox | | ( <_> ) \___| < | \_\ ( <_> > < < 6 - * Firmware |____|_ /\____/ \___ >__|_ \|___ /\____/__/\_ \ 7 - * \/ \/ \/ \/ \/ 8 - * $Id$ 9 - * 10 - * Copyright (C) 2023 Christian Soffke 11 - * 12 - * This program is free software; you can redistribute it and/or 13 - * modify it under the terms of the GNU General Public License 14 - * as published by the Free Software Foundation; either version 2 15 - * of the License, or (at your option) any later version. 16 - * 17 - * This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY 18 - * KIND, either express or implied. 19 - * 20 - ****************************************************************************/ 21 - #include "plugin.h" 22 - 23 - /* Fills mp3entry with metadata retrieved from RAM, if possible, or by reading from 24 - * the file directly. Note that the tagcache only stores a subset of metadata and 25 - * will thus not return certain properties of the file, such as frequency, size, or 26 - * codec. 27 - */ 28 - bool retrieve_id3(struct mp3entry *id3, const char* file) 29 - { 30 - #if defined (HAVE_TAGCACHE) && defined(HAVE_TC_RAMCACHE) && defined(HAVE_DIRCACHE) 31 - if (rb->tagcache_fill_tags(id3, file)) 32 - { 33 - rb->strlcpy(id3->path, file, sizeof(id3->path)); 34 - return true; 35 - } 36 - #endif 37 - 38 - return rb->get_metadata(id3, -1, file); 39 - }
-26
apps/plugins/lib/id3.h
··· 1 - /*************************************************************************** 2 - * __________ __ ___. 3 - * Open \______ \ ____ ____ | | _\_ |__ _______ ___ 4 - * Source | _// _ \_/ ___\| |/ /| __ \ / _ \ \/ / 5 - * Jukebox | | ( <_> ) \___| < | \_\ ( <_> > < < 6 - * Firmware |____|_ /\____/ \___ >__|_ \|___ /\____/__/\_ \ 7 - * \/ \/ \/ \/ \/ 8 - * $Id$ 9 - * 10 - * Copyright (C) 2023 Christian Soffke 11 - * 12 - * This program is free software; you can redistribute it and/or 13 - * modify it under the terms of the GNU General Public License 14 - * as published by the Free Software Foundation; either version 2 15 - * of the License, or (at your option) any later version. 16 - * 17 - * This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY 18 - * KIND, either express or implied. 19 - * 20 - ****************************************************************************/ 21 - #ifndef ID3_H 22 - #define ID3_H 23 - 24 - bool retrieve_id3(struct mp3entry *id3, const char* file); 25 - 26 - #endif /* ID3_H */
+18 -1
apps/plugins/pictureflow/pictureflow.c
··· 33 33 #include "lib/grey.h" 34 34 #include "lib/mylcd.h" 35 35 #include "lib/feature_wrappers.h" 36 - #include "lib/id3.h" 37 36 38 37 /******************************* Globals ***********************************/ 39 38 static fb_data *lcd_fb; ··· 2074 2073 pf_tracks.used = 0; 2075 2074 pf_tracks.cur_idx = -1; 2076 2075 buf_ctx_unlock(); 2076 + } 2077 + 2078 + /* Fills mp3entry with metadata retrieved from RAM, if possible, or by reading from 2079 + * the file directly. Note that the tagcache only stores a subset of metadata and 2080 + * will thus not return certain properties of the file, such as frequency, size, or 2081 + * codec. 2082 + */ 2083 + bool retrieve_id3(struct mp3entry *id3, const char* file) 2084 + { 2085 + #if defined (HAVE_TAGCACHE) && defined(HAVE_TC_RAMCACHE) && defined(HAVE_DIRCACHE) 2086 + if (rb->tagcache_fill_tags(id3, file)) 2087 + { 2088 + rb->strlcpy(id3->path, file, sizeof(id3->path)); 2089 + return true; 2090 + } 2091 + #endif 2092 + 2093 + return rb->get_metadata(id3, -1, file); 2077 2094 } 2078 2095 2079 2096 /**