tsiry-sandratraina.com / rockbox-zig
Rockbox open source high quality audio player as a Music Player Daemon
mpris rockbox mpd libadwaita audio rust zig deno
2
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix a bug in pcmbuf.c when doing offset with modulus.

Causes the track change to go in the wrong buffer (and even be missed
by playback) if the current descriptor for the write index is descriptor
0 because the offset used is "-1" upon track change.

Got nailed by implicit conversion of the % operator dividend to unsigned.

Change-Id: I32538db801ac9d790c8b1b5bd041b09ad4b64d2e

Michael Sevakis 662f7576 363f96b9

+1 -1
+1 -1
apps/pcmbuf.c
··· 241 241 242 242 if (offset != 0) 243 243 { 244 - i = (i + offset) % pcmbuf_desc_count; 244 + i = (i + offset) % (int)pcmbuf_desc_count; 245 245 246 246 /* remainder => modulus */ 247 247 if (i < 0)