Rockbox open source high quality audio player as a Music Player Daemon
mpris rockbox mpd libadwaita audio rust zig deno
2
fork

Configure Feed

Select the types of activity you want to include in your feed.

gcc9: Move structure packing to the struct definition

Silences GCC9 warnings about possible casting misalignments.

Change-Id: I2120638d4d143e9e539b7f240c31653ad55ae4e0

+9 -12
+1 -1
firmware/export/ata.h
··· 101 101 unsigned char reserved_375_385[11]; 102 102 unsigned char vendor_specific_386_510[125]; 103 103 unsigned char chksum; 104 - } __attribute__((packed)); 104 + } __attribute__((packed)) __attribute__((aligned(2))); 105 105 106 106 /* Raw attribute value print formats */ 107 107 enum ata_attr_raw_format
+1 -1
firmware/export/usb_ch9.h
··· 292 292 uint8_t bDescriptorType; 293 293 294 294 uint16_t wString[]; /* UTF-16LE encoded */ 295 - } __attribute__ ((packed)); 295 + } __attribute__ ((packed)) __attribute__((aligned(2))); 296 296 297 297 /* note that "string" zero is special, it holds language codes that 298 298 * the device supports, not Unicode characters.
+7 -10
firmware/usbstack/usb_core.c
··· 119 119 .bNumConfigurations = 1 120 120 }; 121 121 122 - static const struct usb_string_descriptor __attribute__((aligned(2))) 123 - usb_string_iManufacturer = 122 + static const struct usb_string_descriptor usb_string_iManufacturer = 124 123 USB_STRING_INITIALIZER(u"Rockbox.org"); 125 124 126 - static const struct usb_string_descriptor __attribute__((aligned(2))) 127 - usb_string_iProduct = 125 + static const struct usb_string_descriptor usb_string_iProduct = 128 126 USB_STRING_INITIALIZER(u"Rockbox media player"); 129 127 130 - static struct usb_string_descriptor __attribute__((aligned(2))) 131 - usb_string_iSerial = 128 + static struct usb_string_descriptor usb_string_iSerial = 132 129 USB_STRING_INITIALIZER(u"00000000000000000000000000000000000000000"); 133 130 134 131 /* Generic for all targets */ ··· 523 520 static void usb_core_set_serial_function_id(void) 524 521 { 525 522 int i, id = 0; 526 - 523 + 527 524 for(i = 0; i < USB_NUM_DRIVERS; i++) 528 525 if(drivers[i].enabled) 529 526 id |= 1 << i; 530 - 527 + 531 528 usb_string_iSerial.wString[0] = hex[id]; 532 529 } 533 530 ··· 856 853 if(EP_NUM(req->wIndex) < USB_NUM_ENDPOINTS) 857 854 control_handler = 858 855 ep_data[EP_NUM(req->wIndex)].control_handler[EP_DIR(req->wIndex)]; 859 - 856 + 860 857 if(control_handler) 861 858 handled = control_handler(req, reqdata, response_data); 862 - 859 + 863 860 if(!handled) { 864 861 /* nope. flag error */ 865 862 logf("usb bad req %d", req->bRequest);