Rockbox open source high quality audio player as a Music Player Daemon
mpris rockbox mpd libadwaita audio rust zig deno
2
fork

Configure Feed

Select the types of activity you want to include in your feed.

[BugFix] F_CB_ONLY_IF_CHANGED Overlapped NVRAM

the flag I chose was already used for nvram settings
moved both CB flags to unused flags

Change-Id: I9fdbc88460b08654a06b4d5950712947eab04b79

+9 -4
+1
apps/settings.c
··· 1378 1378 SETTINGFLAGS(F_TABLE_SETTING); 1379 1379 SETTINGFLAGS(F_ALLOW_ARBITRARY_VALS); 1380 1380 SETTINGFLAGS(F_CB_ON_SELECT_ONLY); 1381 + SETTINGFLAGS(F_CB_ONLY_IF_CHANGED); 1381 1382 SETTINGFLAGS(F_MIN_ISFUNC); 1382 1383 SETTINGFLAGS(F_MAX_ISFUNC); 1383 1384 SETTINGFLAGS(F_DEF_ISFUNC);
+8 -4
apps/settings_list.h
··· 101 101 }; 102 102 #define F_TABLE_SETTING 0x2000 103 103 #define F_ALLOW_ARBITRARY_VALS 0x4000 104 - #define F_CB_ON_SELECT_ONLY 0x20000 105 - #define F_CB_ONLY_IF_CHANGED 0x40000 104 + 106 105 /* these use the _isfunc_type type for the function */ 107 106 /* typedef int (*_isfunc_type)(void); */ 108 107 #define F_MIN_ISFUNC 0x100000 /* min(above) is function pointer to above type */ ··· 153 152 - a NVRAM setting is removed 154 153 */ 155 154 #define F_TEMPVAR 0x0400 /* used if the setting should be set using a temp var */ 156 - #define F_PADTITLE 0x800 /* pad the title with spaces to force it to scroll */ 155 + #define F_PADTITLE 0x0800 /* pad the title with spaces to force it to scroll */ 157 156 #define F_NO_WRAP 0x1000 /* used if the list should not wrap */ 158 157 159 - #define F_BANFROMQS 0x80000000 /* ban the setting from the quickscreen items */ 158 + #define F_CB_ON_SELECT_ONLY 0x10000000 /* option_callback only called if selected */ 159 + #define F_CB_ONLY_IF_CHANGED 0x20000000 /* option_callback only called if setting changed */ 160 + 160 161 #define F_DEPRECATED 0x40000000 /* DEPRECATED setting, don't write to .cfg */ 162 + #define F_BANFROMQS 0x80000000 /* ban the setting from the quickscreen items */ 163 + 164 + 161 165 struct settings_list { 162 166 uint32_t flags; /* BD__ _SER TFFF NNN_ _ATW PTVC IFRB STTT */ 163 167 void *setting;