tsiry-sandratraina.com / rockbox-zig
Rockbox open source high quality audio player as a Music Player Daemon
mpris rockbox mpd libadwaita audio rust zig deno
2
fork

Configure Feed

Select the types of activity you want to include in your feed.

xrick: Fix a race condition that could result in audio stopping

get_more() can disable audio when there's nothing more to genreate
but that can get called (and "fail") _before_ we set the flag
that audio is turned on. If this occurs, we will incorrecly
set the "audio on" flag after the failure which will prevent
the mixer from being re-started.

(We're at the mercy of thread scheduling)

Change-Id: I4f6c50a71c7ad685ff45f775e7e4b1c61b8b7777

Solomon Peachy e677895e f235443b

+1 -1
+1 -1
apps/plugins/xrick/system/syssnd_rockbox.c
··· 222 222 223 223 if (!isAudioPlaying && fillCount > 0) 224 224 { 225 - rb->mixer_channel_play_data(PCM_MIXER_CHAN_PLAYBACK, get_more, NULL, 0); 226 225 isAudioPlaying = true; 226 + rb->mixer_channel_play_data(PCM_MIXER_CHAN_PLAYBACK, get_more, NULL, 0); 227 227 } 228 228 } 229 229 }