Rockbox open source high quality audio player as a Music Player Daemon
mpris
rockbox
mpd
libadwaita
audio
rust
zig
deno
optimize language.c lang_english_to_id()
speed up comparisons by getting length of the supplied english string
and filter based on length finally use our length to do memcmp since
we know where the null is already
Change-Id: I595f03ae4b08ee0d59bb9adacbe3b69f08991a9e
+4
-3
+4
-3
apps/language.c
+4
-3
apps/language.c
···
137
137
{
138
138
int i;
139
139
unsigned char *ptr = (unsigned char *) core_language_builtin;
140
-
140
+
size_t ptrlen, len = strlen(english);
141
141
for (i = 0; i < LANG_LAST_INDEX_IN_ARRAY; i++) {
142
-
if (!strcmp(ptr, english))
142
+
ptrlen = strlen((char *)ptr);
143
+
if ((ptrlen == len) && memcmp(ptr, english, ptrlen) == 0)
143
144
return i;
144
-
ptr += strlen((char *)ptr) + 1; /* advance pointer to next string */
145
+
ptr += ptrlen + 1; /* advance pointer to next string */
145
146
}
146
147
return -1;
147
148
}